Quota API resource Get and Put data model update by rahuls-microsoft · Pull Request #8424 · Azure/azure-rest-api-specs

rahuls-microsoft · 2020-02-18T20:45:06Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…es": { "properties": {}}} Updating the examples.

azure-pipelines · 2020-02-18T20:45:24Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-18T20:47:11Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e51bc9f with merge commit a57a1e43757f8389eeebab4a37f3216d76c28a93. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-reservations [Logs] [Preview SDK Changes]

azure-arm-reservations-5.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureReservationAPI.js → ./dist/arm-reservations.js...
[npmPack] created ./dist/arm-reservations.js in 399ms

openapi-sdkautomation · 2020-02-18T20:47:13Z

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e51bc9f with merge commit a57a1e43757f8389eeebab4a37f3216d76c28a93. SDK Automation 13.0.17.20191226.1
️✔️preview/reservations/mgmt/2018-06-01 [Logs] [Preview SDK Changes]
- preview.reservations.mgmt.2018-06-01.zip
️✔️preview/reservations/mgmt/2019-04-01 [Logs] [Preview SDK Changes]
- preview.reservations.mgmt.2019-04-01.zip
️✔️preview/reservations/mgmt/2019-07-19-preview [Logs] [Preview SDK Changes]
- preview.reservations.mgmt.2019-07-19-preview.zip
️✔️reservations/mgmt/2017-11-01 [Logs] [Preview SDK Changes]
- reservations.mgmt.2017-11-01.zip

openapi-sdkautomation · 2020-02-18T20:47:14Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e51bc9f with merge commit a57a1e43757f8389eeebab4a37f3216d76c28a93. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Reservations [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Reservations.1.13.0-preview.nupkg
- Microsoft.Azure.Management.Reservations.1.13.0-preview.snupkg

openapi-sdkautomation · 2020-02-18T20:47:16Z

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-02-18T20:47:16Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from e51bc9f with merge commit a57a1e43757f8389eeebab4a37f3216d76c28a93. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-reservations [Logs] [Preview SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

azure-pipelines · 2020-02-18T22:28:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T23:20:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T23:35:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T23:44:08Z

Azure Pipelines successfully started running 1 pipeline(s).

rahuls-microsoft · 2020-02-18T23:45:59Z

Error for spelling check - words - "whican" and "nextpage" is not in any of the files-
What can be done?

2020-02-18T23:21:53.6092167Z cspell specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
2020-02-18T23:21:56.2826358Z ##[error]/home/vsts/work/1/s/specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json:175:225 - Unknown word (whican)
2020-02-18T23:21:56.2837488Z ##[error]/home/vsts/work/1/s/specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json:255:30 - Unknown word (nextpage)
2020-02-18T23:21:56.2839178Z CSpell: Files checked: 1, Issues found: 2 in 1 files

azure-pipelines · 2020-02-19T00:04:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-19T18:52:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-19T18:54:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T03:47:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T03:49:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T05:31:57Z

Azure Pipelines successfully started running 1 pipeline(s).

…st-api-specs

azure-pipelines · 2020-02-21T18:56:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T20:07:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T20:36:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T20:45:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T21:13:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T21:18:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T21:40:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T21:51:41Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T22:16:45Z

Azure Pipelines successfully started running 1 pipeline(s).

rahuls-microsoft · 2020-02-21T22:26:12Z

Closing the pull request, as the errors for spelling and prettier are not going away. It's picking up some old stale file.
The file -
https://github.com/rahuls-microsoft/azure-rest-api-specs/blob/master/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json
Doesn't contain the words - nextpage and whican. So can't fix it.

rahuls-microsoft · 2020-02-24T18:57:33Z

We would like to merge the changes to the master.
Changes: Adding nested
"properties": {
"properties": {

"CurrentQuotaLimitBase": {
"type": "object",
"description": "Quota limits.",
"x-ms-azure-resource": true,
"properties": {
"properties": {
"description": "Quota properties for the resource.",
"$ref": "#/definitions/QuotaProperties"
}
}
},

rahuls-microsoft · 2020-02-24T19:01:00Z

Original PR: #6906
I would like to update the swagger based on current PR - #8424

rahuls-microsoft added 5 commits August 8, 2019 13:04

Adding swagger Spec for Quota RP API.

36279e4

Updated based on the comments.

d710128

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

cf3b90a

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

29b8558

Updating quota Request get and Put objects wrapped inside - "properti…

8126e5d

…es": { "properties": {}}} Updating the examples.

openapi-assignment-bot bot assigned njuCZ Feb 18, 2020

Updating quota properties definition.

be616c8

This was referenced Feb 18, 2020

[AutoPR @azure/arm-reservations] Quota API resource Get and Put data model update AzureSDKAutomation/azure-sdk-for-js#464

Open

[AutoPR azure-mgmt-reservations] Quota API resource Get and Put data model update AzureSDKAutomation/azure-sdk-for-python#360

Open

Fixing Model for put, patch.

c20396d

openapi-sdkautomation bot mentioned this pull request Feb 18, 2020

[AutoPR Microsoft.Azure.Management.Reservations] Quota API resource Get and Put data model update AzureSDKAutomation/azure-sdk-for-net#472

Open

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

82d1db0

Fixing example for QuotaRequest_Create

f0c581a

Refactoring Resource Name to ommon object and updating patch example.

4770299

Fixing examples for Put and patch.

e238691

Running prettier.

c734f81

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

c705c26

Merge from master.

7e4ffe7

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5d2928d

rahuls-microsoft added 2 commits February 21, 2020 10:55

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

636ca64

Merge branch 'master' of https://github.com/rahuls-microsoft/azure-re…

e3e50e5

…st-api-specs

Moving NextLink field, as the build is giving error for nextpage.

afb1820

NextLink update.

84e5fcb

Removing nextLink

702f097

Adding back x-ms-pageable.

cb5e4dd

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

4cd15a4

rahuls-microsoft closed this Feb 21, 2020

rahuls-microsoft reopened this Feb 21, 2020

Comment fix.

baaf105

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

e51bc9f

rahuls-microsoft closed this Feb 21, 2020

Conversation

rahuls-microsoft commented Feb 18, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Feb 18, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

azure-pipelines bot commented Feb 18, 2020

Uh oh!

azure-pipelines bot commented Feb 18, 2020

Uh oh!

azure-pipelines bot commented Feb 18, 2020

Uh oh!

azure-pipelines bot commented Feb 18, 2020

Uh oh!

rahuls-microsoft commented Feb 18, 2020

Uh oh!

azure-pipelines bot commented Feb 19, 2020

Uh oh!

azure-pipelines bot commented Feb 19, 2020

Uh oh!

azure-pipelines bot commented Feb 19, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

rahuls-microsoft commented Feb 21, 2020

Uh oh!

rahuls-microsoft commented Feb 24, 2020

Uh oh!

rahuls-microsoft commented Feb 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

openapi-sdkautomation bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 18, 2020 •

edited

Loading