Added optional PublicNetworkAccess to server properties by emgu-ms · Pull Request #8421 · Azure/azure-rest-api-specs

emgu-ms · 2020-02-18T18:28:54Z

Latest improvements:

We are adding an optional boolean property, PublicNetworkAccess, to the Server ARM Api. This is used to determine whether we allow public endpoints to connect to databases under this server or not.

This was already signed off in azure-rest-api-specs-pr:
https://github.com/Azure/azure-rest-api-specs-pr/pull/1083

Note: We have some deadlines to hit so if we could get quick signoff on this, that would be great :)

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Pull from Azure-rest-api-specs for latest changes

azure-pipelines · 2020-02-18T18:29:12Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-18T18:30:33Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d99fc40 with merge commit 99b4e9d. SDK Automation 13.0.17.20191226.1
️✔️preview/sql/mgmt/2015-05-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2015-05-01-preview.zip
️✔️preview/sql/mgmt/2017-03-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2017-03-01-preview.zip
️✔️preview/sql/mgmt/2017-10-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2017-10-01-preview.zip
️✔️preview/sql/mgmt/2018-06-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2018-06-01-preview.zip
️✔️preview/sql/mgmt/v3.0 [Logs] [Release SDK Changes]
- preview.sql.mgmt.v3.0.zip
️✔️sql/mgmt/2014-04-01 [Logs] [Release SDK Changes]
- sql.mgmt.2014-04-01.zip

openapi-sdkautomation · 2020-02-18T18:30:38Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d99fc40 with merge commit 99b4e9d. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-sql [Logs] [Release SDK Changes]

azure-arm-sql-7.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
[npmPack] created ./dist/arm-sql.js in 1.8s

openapi-sdkautomation · 2020-02-18T18:30:42Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d99fc40 with merge commit 99b4e9d. SDK Automation 13.0.17.20191226.1
️✔️sdk/sql/mgmt-v2014_04_01 [Logs] [Release SDK Changes]
️✔️sdk/sql/mgmt-v2015_05_01_preview [Logs] [Release SDK Changes]

⚠️sdk/sql/mgmt-v2017_03_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/sql/mgmt-v2017_10_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/sql/mgmt-v2018_06_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-18T18:30:43Z

azure-sdk-for-net - Release

🔄 inProgress [Logs] [Expand Details]

🔄 Generate from d99fc40 with merge commit 99b4e9d. SDK Automation 13.0.17.20191226.1

openapi-sdkautomation · 2020-02-18T18:30:44Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d99fc40 with merge commit 99b4e9d. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-sql [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

azure-pipelines · 2020-02-18T20:43:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T21:00:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T23:02:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-19T00:35:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-21T00:56:31Z

Azure Pipelines successfully started running 1 pipeline(s).

jaredmoo · 2020-02-21T01:57:04Z

          "type": "string"
+        },
+        "publicNetworkAccess": {
+          "description": "Whether or not public endpoint access is allowed for this server.  Value is optional but if passed in, must be 'Enabled' or 'Disabled'",


Value is optional but if passed in, must be 'Enabled' or 'Disabled'
I think that documentation explaining this will be automatically written (when generating SDKs) based on the x-ms-enum property. However, I think that what "public endpoint access" is might not be sufficiently obvious to somebody who doesn't have context.

OK I can discuss with Rohit as to what is better documentation for this after this round is merged in first

emgu-ms · 2020-02-21T22:09:46Z

@zikalino Do you know why sdk automation failure is occurring? Its failing on permissions denied

azure-pipelines · 2020-02-24T06:13:20Z

Azure Pipelines successfully started running 1 pipeline(s).

zikalino · 2020-02-24T18:54:54Z

sdk failure unrelated

* Add PublicNetworkAccess option to server properties * Remove IdentityTypeWithNone unrelated changes to prevent test breaking * Remove None from enum type - unrelated changes to prevent test breaking * Prettify swagger file

emgu-ms and others added 3 commits June 12, 2019 11:04

Merge pull request #1 from Azure/master

534fc87

Pull from Azure-rest-api-specs for latest changes

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

5932a1a

Add PublicNetworkAccess option to server properties

daa8eea

emgu-ms requested a review from jaredmoo as a code owner February 18, 2020 18:28

openapi-assignment-bot Bot assigned zikalino Feb 18, 2020

Remove IdentityTypeWithNone unrelated changes to prevent test breaking

25d9097

Remove None from enum type - unrelated changes to prevent test breaking

d0d171d

This was referenced Feb 18, 2020

[AutoPR azure-mgmt-sql] Added optional PublicNetworkAccess to server properties AzureSDKAutomation/azure-sdk-for-python#358

Closed

[AutoPR @azure/arm-sql] Added optional PublicNetworkAccess to server properties AzureSDKAutomation/azure-sdk-for-js#463

Closed

Prettify swagger file

d99fc40

emgu-ms changed the title ~~Deny public access~~ [DO NOT MERGE] Added optional PublicNetworkAccess to server properties Feb 19, 2020

jaredmoo approved these changes Feb 21, 2020

View reviewed changes

jaredmoo reviewed Feb 21, 2020

View reviewed changes

emgu-ms changed the title ~~[DO NOT MERGE] Added optional PublicNetworkAccess to server properties~~ Added optional PublicNetworkAccess to server properties Feb 24, 2020

zikalino merged commit 99b4e9d into Azure:master Feb 24, 2020

Conversation

emgu-ms commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Feb 18, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

azure-pipelines Bot commented Feb 18, 2020

Uh oh!

azure-pipelines Bot commented Feb 18, 2020

Uh oh!

azure-pipelines Bot commented Feb 18, 2020

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

azure-pipelines Bot commented Feb 21, 2020

Uh oh!

jaredmoo Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

emgu-ms Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

emgu-ms commented Feb 21, 2020

Uh oh!

azure-pipelines Bot commented Feb 24, 2020

Uh oh!

zikalino commented Feb 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emgu-ms commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 18, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 18, 2020 •

edited

Loading