Add 2019-06-01-preview API version for AAD Admin on Azure SQL Server by amolagar5 · Pull Request #8340 · Azure/azure-rest-api-specs

amolagar5 · 2020-02-07T23:30:04Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ption

azure-pipelines · 2020-02-07T23:30:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-08T00:04:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-11T08:06:56Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-11T08:16:43Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1
️✔️preview/sql/mgmt/2015-05-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2015-05-01-preview.zip
️✔️preview/sql/mgmt/2017-03-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2017-03-01-preview.zip
️✔️preview/sql/mgmt/2017-10-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2017-10-01-preview.zip
️✔️preview/sql/mgmt/2018-06-01-preview [Logs] [Release SDK Changes]
- preview.sql.mgmt.2018-06-01-preview.zip
️✔️preview/sql/mgmt/v3.0 [Logs] [Release SDK Changes]
- preview.sql.mgmt.v3.0.zip
️✔️sql/mgmt/2014-04-01 [Logs] [Release SDK Changes]
- sql.mgmt.2014-04-01.zip

openapi-sdkautomation · 2020-02-11T08:16:45Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1
️✔️sdk/sql/mgmt-v2014_04_01 [Logs] [Release SDK Changes]
️✔️sdk/sql/mgmt-v2015_05_01_preview [Logs] [Release SDK Changes]

⚠️sdk/sql/mgmt-v2017_03_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn]   symbol:   class UUID
[mvn]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[30,147] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/JobStepExecutions.java:[43,192] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: interface com.microsoft.azure.management.sql.v2017_03_01_preview.JobStepExecutions
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/SensitivityLabelsImpl.java:[59,172] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.SensitivityLabelsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,158] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/DatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,117] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.DatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[47,154] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_03_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_03_01_preview/implementation/JobStepExecutionsImpl.java:[63,199] cannot find symbol
[mvn] [ERROR]   symbol:   class UUID
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_03_01_preview.implementation.JobStepExecutionsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/sql/mgmt-v2017_10_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[55,167] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2017_10_01_preview/src/main/java/com/microsoft/azure/management/sql/v2017_10_01_preview/implementation/ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl.java:[71,126] cannot find symbol
[mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2017_10_01_preview.implementation.ManagedDatabaseVulnerabilityAssessmentRuleBaselinesImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/sql/mgmt-v2018_06_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn]   symbol:   class SensitivityLabelSource
[mvn]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-sql: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/sql/mgmt-v2018_06_01_preview/src/main/java/com/microsoft/azure/management/sql/v2018_06_01_preview/implementation/ManagedDatabaseSensitivityLabelsImpl.java:[68,182] cannot find symbol
[mvn] [ERROR]   symbol:   class SensitivityLabelSource
[mvn] [ERROR]   location: class com.microsoft.azure.management.sql.v2018_06_01_preview.implementation.ManagedDatabaseSensitivityLabelsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-11T08:16:48Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-sql [Logs] [Release SDK Changes]

azure-arm-sql-7.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
[npmPack] created ./dist/arm-sql.js in 1.8s

openapi-sdkautomation · 2020-02-11T08:17:16Z

azure-sdk-for-net - Release

🔄 inProgress [Logs] [Expand Details]

🔄 Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1

openapi-sdkautomation · 2020-02-11T08:17:28Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d4a1890 with merge commit f4e7ef1. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-sql [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

azure-pipelines · 2020-02-11T08:53:16Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-11T09:02:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-11T09:02:30Z

Azure Pipelines successfully started running 1 pipeline(s).

amolagar5 · 2020-02-11T09:04:12Z

Please take a look as possible. All issues have been resolved.

azure-pipelines · 2020-02-13T04:08:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T04:38:23Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar

@amolagar5 - few comments.

ravbhatnagar · 2020-02-21T18:58:35Z

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/disableAzureADOnlyAuthentication": {


why is there a POST action to disable this? its a property on the resource type, and so can be updated via a PATCH.

its not for patch. its an action. and had no body, only updates a value implicitly.
Eventually customers will use RBAC to assign it in different roles. like$role.NotActions.Remove("Microsoft.Sql/servers/disableAzureADOnlyAuthentication/action")

OK, looks like different RBAC may be needed to allow modifying this property - someone may not have /write access on the resource but they can still update this property.

yes. that is the intention here. to keep permissions separate for setting and un-setting that value.

ravbhatnagar · 2020-02-21T21:06:46Z

signing off from ARM side.

azure-pipelines · 2020-02-22T00:18:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-22T05:00:30Z

Azure Pipelines successfully started running 1 pipeline(s).

…zure#8340)

amolagar5 added 2 commits February 7, 2020 15:20

Add 2019-06-01-preview API version for AAD Admin with AAD Auth only o…

c823db5

…ption

update readme.md

0d634a2

amolagar5 requested a review from jaredmoo as a code owner February 7, 2020 23:30

openapi-assignment-bot Bot assigned fengzhou-msft Feb 7, 2020

Make prettier changes

0d7e7e0

fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 8, 2020

Update the examples file

321fc7e

Fix the example files

ae4645b

update the files

7b9e289

Fix for prettier

2d01214

jaredmoo approved these changes Feb 19, 2020

View reviewed changes

ravbhatnagar reviewed Feb 21, 2020

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Feb 21, 2020

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 21, 2020

amolagar5 changed the title ~~Add 2019-06-01-preview API version for AAD Admin on SQL Server~~ Add 2019-06-01-preview API version for AAD Admin on Azure SQL Server Feb 22, 2020

fengzhou-msft approved these changes Feb 22, 2020

View reviewed changes

Merge branch 'master' into master

d4a1890

fengzhou-msft merged commit f4e7ef1 into Azure:master Feb 22, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add 2019-06-01-preview API version for AAD Admin on Azure SQL Server (A…

f8fb32b

…zure#8340)

Conversation

amolagar5 commented Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Feb 7, 2020

Uh oh!

azure-pipelines Bot commented Feb 8, 2020

Uh oh!

azure-pipelines Bot commented Feb 11, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

azure-pipelines Bot commented Feb 11, 2020

Uh oh!

azure-pipelines Bot commented Feb 11, 2020

Uh oh!

azure-pipelines Bot commented Feb 11, 2020

Uh oh!

amolagar5 commented Feb 11, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ravbhatnagar Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

amolagar5 Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

amolagar5 Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Feb 21, 2020

Uh oh!

azure-pipelines Bot commented Feb 22, 2020

Uh oh!

azure-pipelines Bot commented Feb 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amolagar5 commented Feb 7, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 11, 2020 •

edited

Loading

amolagar5 Feb 21, 2020 •

edited

Loading