Skip to content

Resolve validation issues and change version to 7.1-preview#8331

Merged
tjprescott merged 7 commits intoAzure:dev-keyvault-Microsoft.KeyVault-7.1from
heaths:keyvault-swagger
Feb 7, 2020
Merged

Resolve validation issues and change version to 7.1-preview#8331
tjprescott merged 7 commits intoAzure:dev-keyvault-Microsoft.KeyVault-7.1from
heaths:keyvault-swagger

Conversation

@heaths
Copy link
Member

@heaths heaths commented Feb 6, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths heaths requested a review from msfcolombo February 7, 2020 20:07
@azure-pipelines
Copy link

Pull request contains merge conflicts.

Resolves validation error when adding back 7.0-preview.
Resolves validation errors that pre-existed OpenAPI Hub validation.
...then removes 2020-01-23.
Not supported, but necessary to generate source since JsonWebKeyOperation is defined in two places and must have the same definition.
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjprescott tjprescott merged commit 245f490 into Azure:dev-keyvault-Microsoft.KeyVault-7.1 Feb 7, 2020
@heaths heaths deleted the keyvault-swagger branch February 11, 2020 18:32
heaths added a commit that referenced this pull request Feb 11, 2020
* Resolve a few validation errors

* Restore preview/7.0 since service supports it

* Change api-version to 7.1-preview

* Add reference to 7.0-preview swagger

Resolves validation error when adding back 7.0-preview.

* Fix 7.0-preview examples

Resolves validation errors that pre-existed OpenAPI Hub validation.

* Backport 2020-01 changes to 2019-09

...then removes 2020-01-23.

* Add "import" to KeyUpdateParameters

Not supported, but necessary to generate source since JsonWebKeyOperation is defined in two places and must have the same definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants