Skip to content

Conversation

@maksimkim
Copy link
Member

@maksimkim maksimkim commented Feb 1, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6bd0967 with merge commit b2a2178. SDK Automation 13.0.17.20200311.2
  • ⚠️azure-mgmt-apimanagement [Logs]  [Release SDK Changes] Breaking Change Detected
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
    [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
    [ChangeLog] Size of delta 12.559% size of original (original: 232886 chars, delta: 29248 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog] - Model SchemaContract has a new parameter definitions
    [ChangeLog] - Model SchemaContract has a new parameter value
    [ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter disable_gateway
    [ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter api_version_constraint
    [ChangeLog] - Model ApiManagementServiceBaseProperties has a new parameter developer_portal_url
    [ChangeLog] - Model IdentityProviderUpdateParameters has a new parameter signin_tenant
    [ChangeLog] - Model AdditionalLocation has a new parameter disable_gateway
    [ChangeLog] - Model DiagnosticContract has a new parameter verbosity
    [ChangeLog] - Model DiagnosticContract has a new parameter http_correlation_protocol
    [ChangeLog] - Model DiagnosticContract has a new parameter log_client_ip
    [ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter disable_gateway
    [ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter api_version_constraint
    [ChangeLog] - Model ApiManagementServiceUpdateParameters has a new parameter developer_portal_url
    [ChangeLog] - Model ApiManagementServiceIdentity has a new parameter user_assigned_identities
    [ChangeLog] - Model ApiManagementServiceResource has a new parameter disable_gateway
    [ChangeLog] - Model ApiManagementServiceResource has a new parameter api_version_constraint
    [ChangeLog] - Model ApiManagementServiceResource has a new parameter developer_portal_url
    [ChangeLog] - Model UserCreateParameters has a new parameter app_type
    [ChangeLog] - Model TagDescriptionContract has a new parameter tag_id
    [ChangeLog] - Model IdentityProviderContract has a new parameter signin_tenant
    [ChangeLog] - Model IdentityProviderBaseParameters has a new parameter signin_tenant
    [ChangeLog] - Added operation SubscriptionOperations.list_secrets
    [ChangeLog] - Added operation AuthorizationServerOperations.list_secrets
    [ChangeLog] - Added operation IdentityProviderOperations.list_secrets
    [ChangeLog] - Added operation OpenIdConnectProviderOperations.list_secrets
    [ChangeLog] - Added operation TenantAccessOperations.list_secrets
    [ChangeLog] - Added operation TenantAccessGitOperations.list_secrets
    [ChangeLog] - Added operation DelegationSettingsOperations.list_secrets
    [ChangeLog] - Added operation group PolicyDescriptionOperations
    [ChangeLog] - Added operation group GatewayApiOperations
    [ChangeLog] - Added operation group NamedValueOperations
    [ChangeLog] - Added operation group GatewayOperations
    [ChangeLog] - Added operation group GatewayHostnameConfigurationOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog] - Parameter capacity of model ApiManagementServiceSkuProperties is now required
    [ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
    [ChangeLog] - Operation ApiTagDescriptionOperations.get_entity_tag has a new signature
    [ChangeLog] - Operation ApiTagDescriptionOperations.create_or_update has a new signature
    [ChangeLog] - Operation ApiTagDescriptionOperations.delete has a new signature
    [ChangeLog] - Operation ApiTagDescriptionOperations.get has a new signature
    [ChangeLog] - Operation ApiSchemaOperations.create_or_update has a new signature
    [ChangeLog] - Model SchemaContract no longer has parameter document
    [ChangeLog] - Model AuthorizationServerContractBaseProperties no longer has parameter client_secret
    [ChangeLog] - Model DiagnosticContract no longer has parameter enable_http_correlation_headers
    [ChangeLog] - Model AuthenticationSettingsContract no longer has parameter subscription_key_required
    [ChangeLog] - Removed operation group PolicySnippetOperations
    [ChangeLog] - Removed operation group PropertyOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 1, 2020

azure-sdk-for-net

failed [Logs] [Expand Details]
  • Generate from 6bd0967 with merge commit e481335b48e7c5a8a41b88fcde1d441dc6ab9487. SDK Automation 13.0.17.20200311.2
  • Microsoft.Azure.Management.ApiManagement [Logs
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {} 
      SDK Repository Package Error: Error: git checkout sdkAutomation/Microsoft.Azure.Management.ApiManagement error: Your local changes to the following files would be overwritten by checkout:
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiDiagnosticOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiExportOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueAttachmentOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueCommentOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiManagementClient.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiManagementOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiManagementServiceOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiManagementServiceSkusOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationPolicyOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiPolicyOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiProductOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiReleaseOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiRevisionOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiSchemaOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiTagDescriptionOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiVersionSetOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/AuthorizationServerOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/BackendOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/CacheOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/CertificateOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/DelegationSettingsOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/DiagnosticOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/EmailTemplateOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GroupOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GroupUserOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IApiManagementClient.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IdentityProviderOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IssueOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/LoggerOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/AdditionalLocation.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiContractProperties.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiCreateOrUpdateParameter.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiEntityBaseContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiManagementServiceBaseProperties.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ApiManagementServiceIdentity.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/
      error: The following untracked working tree files would be overwritten by checkout:
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayApiOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayApiOperationsExtensions.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayHostnameConfigurationOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayHostnameConfigurationOperationsExtensions.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/GatewayOperationsExtensions.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IGatewayApiOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IGatewayHostnameConfigurationOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/IGatewayOperations.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/AppType.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/AssociationContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayApiGetEntityTagHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayCreateOrUpdateHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayGetEntityTagHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayGetHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayHostnameConfigurationContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayHostnameConfigurationCreateOrUpdateHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayHostnameConfigurationGetEntityTagHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayHostnameConfigurationGetHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayKeyRegenerationRequestContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayKeysContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayListKeysHeaders.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayTokenContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/GatewayTokenRequestContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ProvisioningState.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/ResourceLocationDataContract.cs
      	sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/Models/UserIdentityProperties.cs
      Please move or remove them before you switch branches.
      Aborting
      , {}

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @solankisamir solankisamir added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sanjaiganesh
    Copy link
    Contributor

    @maksimkim please take a look at the pending comments..

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @solankisamir
    Copy link
    Member

    @sanjaiganesh can you take a look again.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ravbhatnagar
    Copy link
    Contributor

    signing off from ARM side

    @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 14, 2020
    @solankisamir
    Copy link
    Member

    @allenjzhang can you merge this PR?

    @solankisamir
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 18, 2020

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @allenjzhang
    Copy link
    Contributor

    /azp run automation - sdk

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @allenjzhang allenjzhang merged commit b2a2178 into Azure:master Mar 18, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    …e#8282)
    
    * add gateway related description
    
    * add GatewayHostnameConfigurationCollection
    
    * fixes
    
    * more fixes
    
    * hoist gateway keys property
    
    * prettier
    
    * fix version
    
    * armify action names and flatten their request payload
    
    * + body for gateway/api association
    
    * +definitions
    
    * typo fix
    
    * gateway.region -> gateway.locationData
    
    * fix example
    
    Co-authored-by: Maxim Kim <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    API Management ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    9 participants