2020-02-01-preview for Media Services LVA by microsoft-rin · Pull Request #8281 · Azure/azure-rest-api-specs

microsoft-rin · 2020-02-01T00:14:11Z

Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Changes to MediaGraph model Changing PUT from sync to async Fixing some description

azure-pipelines · 2020-02-01T00:14:28Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-01T00:16:00Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-02-01T00:16:02Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1
️✔️mediaservices/mgmt/2015-10-01 [Logs] [Release SDK Changes]
- mediaservices.mgmt.2015-10-01.zip
️✔️mediaservices/mgmt/2018-07-01 [Logs] [Release SDK Changes]
- mediaservices.mgmt.2018-07-01.zip
️✔️preview/mediaservices/mgmt/2018-03-30-preview [Logs] [Release SDK Changes]
- preview.mediaservices.mgmt.2018-03-30-preview.zip
️✔️preview/mediaservices/mgmt/2018-06-01-preview [Logs] [Release SDK Changes]
- preview.mediaservices.mgmt.2018-06-01-preview.zip
️✔️preview/mediaservices/mgmt/2019-05-01-preview [Logs] [Release SDK Changes]
- preview.mediaservices.mgmt.2019-05-01-preview.zip

openapi-sdkautomation · 2020-02-01T00:16:02Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Media [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Media.2.0.4.nupkg
- Microsoft.Azure.Management.Media.2.0.4.snupkg

openapi-sdkautomation · 2020-02-01T00:19:27Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-mediaservices [Logs] [Release SDK Changes]

azure-arm-mediaservices-7.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureMediaServices.js → ./dist/arm-mediaservices.js...
[npmPack] created ./dist/arm-mediaservices.js in 731ms

openapi-sdkautomation · 2020-02-01T00:21:07Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 02b1e31 with merge commit 77fa990. SDK Automation 13.0.17.20191226.1
️✔️sdk/mediaservices/mgmt-v2015_10_01 [Logs] [Release SDK Changes]
️✔️sdk/mediaservices/mgmt-v2018_03_30_preview [Logs] [Release SDK Changes]
️✔️sdk/mediaservices/mgmt-v2018_06_01_preview [Logs] [Release SDK Changes]
️✔️sdk/mediaservices/mgmt-v2018_07_01 [Logs] [Release SDK Changes]
️✔️sdk/mediaservices/mgmt-v2019_05_01_preview [Logs] [Release SDK Changes]

azure-pipelines · 2020-02-02T04:53:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-02T06:49:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-03T17:40:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T00:03:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T00:03:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T20:10:08Z

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 6bf3a73.

azure-pipelines · 2020-02-13T20:10:38Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T20:11:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T21:56:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T22:02:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-13T23:16:37Z

Azure Pipelines successfully started running 1 pipeline(s).

microsoft-rin · 2020-02-13T23:30:37Z

Hi @pilor @allenjzhang @lirenhe , after some internal discussion within our team after the review meeting, we've decided to hold off the changes to async PUT, and just release the changes of adding a few new properties for media graph entity (our main ARM entity).

As suggested by @pilor , we uploaded the previous API version to commit 8 for easier review. So please compare the latest iteration with that commit as below screenshot.

majastrz · 2020-02-14T20:56:22Z

Reset labels due to changes. Reviewing...

ravbhatnagar

Signing off from ARM side

* 2020-02-01-preview for Media Services LVA Changes to MediaGraph model Changing PUT from sync to async Fixing some description * Prettier and model validations fix * Fixing validations * Fixing version in Common.json * Using common types.json * Updating new version * Adding old version * Revert "Adding old version" This reverts commit 6bf3a73. * Using common types * Using 200 for operation locatio header. * Fixing validation errors

2020-02-01-preview for Media Services LVA

ff91d1c

Changes to MediaGraph model Changing PUT from sync to async Fixing some description

openapi-assignment-bot Bot assigned allenjzhang Feb 1, 2020

openapi-sdkautomation Bot mentioned this pull request Feb 1, 2020

[AutoPR Microsoft.Azure.Management.Media] 2020-02-01-preview for Media Services LVA AzureSDKAutomation/azure-sdk-for-net#386

Closed

Prettier and model validations fix

13a8b5c

Fixing validations

a5aab54

lirenhe reviewed Feb 3, 2020

View reviewed changes

Comment thread ...cation/mediaservices/resource-manager/Microsoft.Media/preview/2020-02-01-preview/Common.json Outdated

lirenhe added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Feb 3, 2020

Fixing version in Common.json

0ccaace

allenjzhang reviewed Feb 3, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020

Using common types.json

6c08aad

allenjzhang reviewed Feb 9, 2020

View reviewed changes

Comment thread ...n/mediaservices/resource-manager/Microsoft.Media/preview/2020-02-01-preview/MediaGraphs.json Outdated

Comment thread ...n/mediaservices/resource-manager/Microsoft.Media/preview/2020-02-01-preview/MediaGraphs.json

allenjzhang removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Feb 9, 2020

Updating new version

a2f8210

microsoft-rin added 2 commits February 13, 2020 12:10

Adding old version

6bf3a73

Revert "Adding old version"

c1cdf21

This reverts commit 6bf3a73.

Using common types

1bdb611

Using 200 for operation locatio header.

a40ca5e

Fixing validation errors

02b1e31

majastrz added ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Feb 14, 2020

majastrz reviewed Feb 14, 2020

View reviewed changes

Comment thread ...Microsoft.Media/preview/2020-02-01-preview/examples/media-graph-create-encrypted-source.json

majastrz reviewed Feb 15, 2020

View reviewed changes

Comment thread ...n/mediaservices/resource-manager/Microsoft.Media/preview/2020-02-01-preview/MediaGraphs.json

ravbhatnagar reviewed Feb 20, 2020

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 20, 2020

allenjzhang self-requested a review February 24, 2020 19:41

allenjzhang approved these changes Feb 24, 2020

View reviewed changes

allenjzhang merged commit 77fa990 into Azure:master Feb 24, 2020

Conversation

microsoft-rin commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Feb 1, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

azure-pipelines Bot commented Feb 2, 2020

Uh oh!

azure-pipelines Bot commented Feb 2, 2020

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 5, 2020

Uh oh!

azure-pipelines Bot commented Feb 5, 2020

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

microsoft-rin commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majastrz commented Feb 14, 2020

Uh oh!

Uh oh!

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

microsoft-rin commented Feb 1, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 1, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 1, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 1, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 1, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 1, 2020 •

edited

Loading

microsoft-rin commented Feb 13, 2020 •

edited

Loading