Skip to content

[Securityinsight] Add DnsDomain to AccountEntityProperties#8237

Merged
allenjzhang merged 1 commit into
Azure:masterfrom
dosegal:AddDnsDomainAccountProperty
Feb 24, 2020
Merged

[Securityinsight] Add DnsDomain to AccountEntityProperties#8237
allenjzhang merged 1 commit into
Azure:masterfrom
dosegal:AddDnsDomainAccountProperty

Conversation

@dosegal
Copy link
Copy Markdown
Contributor

@dosegal dosegal commented Jan 27, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@dosegal dosegal requested review from nirgfani and pilor January 27, 2020 12:43
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9381ecf with merge commit 7e6f562. SDK Automation 13.0.17.20191226.1 
    Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9381ecf with merge commit 7e6f562. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 27, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9381ecf with merge commit 7e6f562. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Jan 27, 2020
    Closed
    @allenjzhang allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2020
    @allenjzhang
    Copy link
    Copy Markdown
    Contributor

    allenjzhang commented Jan 27, 2020

    Once ARM review approve this, I will complete the merge. Thanks.

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 27, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    3 similar comments
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 28, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 28, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Jan 28, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 12, 2020
    majastrz
    majastrz approved these changes Feb 12, 2020
    View reviewed changes
    Copy link
    Copy Markdown
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @dosegal
    Copy link
    Copy Markdown
    Contributor Author

    dosegal commented Feb 13, 2020

    @allenjzhang can you please complete the merge?

    @dosegal
    Copy link
    Copy Markdown
    Contributor Author

    dosegal commented Feb 19, 2020

    @allenjzhang please approve, thanks

    @dosegal dosegal requested a review from raych1 February 20, 2020 13:53
    @dosegal
    Copy link
    Copy Markdown
    Contributor Author

    dosegal commented Feb 20, 2020

    @raych1 could you please complete this PR?

    @allenjzhang allenjzhang merged commit 7e6f562 into Azure:master Feb 24, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @dosegal @00Kai0
    add dnsDomaon to AccountEntityProperties (Azure#8237)
    6052bd2
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @majastrz majastrz majastrz approved these changes

    @pilor pilor Awaiting requested review from pilor

    @nirgfani nirgfani Awaiting requested review from nirgfani

    @raych1 raych1 Awaiting requested review from raych1

    Assignees

    @allenjzhang allenjzhang

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @dosegal @allenjzhang @majastrz