Skip to content

[Support RP] Updating documentation and examples for 2019-05-01-preview version#8229

Merged
allenjzhang merged 14 commits intoAzure:masterfrom
shahbj79:master
Jan 28, 2020
Merged

[Support RP] Updating documentation and examples for 2019-05-01-preview version#8229
allenjzhang merged 14 commits intoAzure:masterfrom
shahbj79:master

Conversation

@shahbj79
Copy link
Contributor

@shahbj79 shahbj79 commented Jan 25, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 25, 2020

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 25, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 25, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 25, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 25, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 61376e7 with merge commit fcb0149. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 25, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 61376e7 with merge commit fcb0149. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Support [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 25, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 25, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 61376e7 with merge commit fcb0149. SDK Automation 13.0.17.20191226.1 
      Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/_microsoft_support.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/models/_microsoft_support_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/_communications_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/_problem_classifications_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/_services_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/operations/_support_tickets_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-support/azure/mgmt/support/version.py

    This was referenced Jan 25, 2020
    Closed
    Closed
    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 25, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @allenjzhang
    Copy link
    Contributor

    allenjzhang commented Jan 25, 2020

    /azp run

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 25, 2020

    Azure Pipelines successfully started running 3 pipeline(s).

    @shahbj79
    Copy link
    Contributor Author

    shahbj79 commented Jan 27, 2020

    @allenjzhang - Can you please help review? This PR is to update the documentation. There is no change to contracts/APIs.

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 28, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @allenjzhang allenjzhang merged commit fcb0149 into Azure:master Jan 28, 2020
    ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
    @shahbj79 @ssripadham
    [Support RP] Updating documentation and examples for 2019-05-01-previ…
    4657476 
    …ew version (Azure#8229)

* support rp swagger for public preview

* fixing spelling error

* addressing review comments

* adding common resource properties

* fixing readme.csharp.md

* adding example that was missed

* fix syntax error in swagger spec

* fixing model validation error

* put support for communication resource and other updates based on comments

* updating communication to be async, fixing version on async and location headers

* updating documentation and examples

* fixing spelling error

* ran prettier fix and addressing review comments
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @shahbj79 @00Kai0
    [Support RP] Updating documentation and examples for 2019-05-01-previ…
    f6d47ed 
    …ew version (Azure#8229)

* support rp swagger for public preview

* fixing spelling error

* addressing review comments

* adding common resource properties

* fixing readme.csharp.md

* adding example that was missed

* fix syntax error in swagger spec

* fixing model validation error

* put support for communication resource and other updates based on comments

* updating communication to be async, fixing version on async and location headers

* updating documentation and examples

* fixing spelling error

* ran prettier fix and addressing review comments
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @allenjzhang allenjzhang allenjzhang approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @allenjzhang allenjzhang

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @shahbj79 @allenjzhang

    Comments