Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverabl…#8223
Merged
allenjzhang merged 3 commits intoAzure:dev-keyvault-Microsoft.KeyVault-7.1from Jan 25, 2020
Merged
Conversation
…eDays Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays
|
Azure Pipelines successfully started running 1 pipeline(s). |
heaths
requested changes
Jan 23, 2020
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
The management plane needs to have a new revision as well. I can show you how, or start one you can target. Mainly, just create a new directory like preview/2020-01-23, copy stable/2019-09-01 to it, and make your changes to it.
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/keyvault.json
Outdated
Show resolved
Hide resolved
Revision RP to 2020-01-23
|
Azure Pipelines successfully started running 1 pipeline(s). |
heaths
approved these changes
Jan 24, 2020
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
I diff'd the stable/2019-09-01 and preview/2020-01-23 directories and they look good. I see only version changes and the softDeleteInDays changes.
johanste
reviewed
Jan 24, 2020
specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-01-23/keyvault.json
Show resolved
Hide resolved
Set "default": true for enableSoftDelete when put
|
Azure Pipelines successfully started running 1 pipeline(s). |
schaabs
approved these changes
Jan 24, 2020
Contributor
|
Manual merge into feature branch until we fix the permission issue. |
heaths
pushed a commit
that referenced
this pull request
Feb 11, 2020
#8223) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays * RP revision Revision RP to 2020-01-23 * Set "default": true for enableSoftDelete when put Set "default": true for enableSoftDelete when put
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eDays
Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.