Skip to content

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenjzhang merged 5 commits into from
Jan 31, 2020
Merged

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #8210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd21cfc
add disabled property to digest config, change type of frequency prop…
parkhyukjun89 Jan 22, 2020
09e1aa4
fix examples
parkhyukjun89 Jan 22, 2020
fb66ef1
change bool to enum
parkhyukjun89 Jan 22, 2020
28509dd
add name property
parkhyukjun89 Jan 23, 2020
e6c7e08
apply prettier and fix frequency description
parkhyukjun89 Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@
"description": "Advisor configuration name. Value must be 'default'",
"required": true,
"type": "string",
"enum": ["default"],
"enum": [
"default"
],
"x-ms-enum": {
"name": "ConfigurationName",
"modelAsString": true
Expand Down Expand Up @@ -262,7 +264,9 @@
"description": "Advisor configuration name. Value must be 'default'",
"required": true,
"type": "string",
"enum": ["default"],
"enum": [
"default"
],
"x-ms-enum": {
"name": "ConfigurationName",
"modelAsString": true
Expand Down Expand Up @@ -858,13 +862,18 @@
"description": "Advisor Digest configuration entity",
"type": "object",
"properties": {
"name": {
"description": "Name of digest configuration. Value is case-insensitive and must be unique within a subscription.",
"type": "string"
},
"actionGroupResourceId": {
"description": "Action group resource id used by digest.",
"type": "string"
},
"frequency": {
"description": "Frequency that digest will be triggered. Value must conform to ISO 8601 standard and must be greater than equal to 7 day and less than or equal to 30 days.",
"type": "string"
"format": "int32",
"description": "Frequency that digest will be triggered, in days. Value must be between 7 and 30 days inclusive.",
"type": "integer"
},
"categories": {
"description": "Categories to send digest for. If categories are not provided, then digest will be sent for all categories.",
Expand All @@ -887,6 +896,18 @@
"language": {
"description": "Language for digest content body. Value must be ISO 639-1 code for one of Azure portal supported languages. Otherwise, it will be converted into one. Default value is English (en).",
"type": "string"
},
"state": {
"description": "State of digest configuration.",
"enum": [
"Active",
"Disabled"
],
"type": "string",
"x-ms-enum": {
"name": "DigestConfigState",
"modelAsString": true
}
}
}
},
Expand Down
14 changes: 9 additions & 5 deletions ...or/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/CreateConfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,18 @@
"exclude": true,
"digests": [
{
"name": "digestConfigName",
"actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
"frequency": "P30D",
"frequency": 30,
"categories": [
"HighAvailability",
"Security",
"Performance",
"Cost",
"OperationalExcellence"
],
"language": "en"
"language": "en",
"state": "Active"
}
]
}
Expand All @@ -36,20 +38,22 @@
"exclude": true,
"digests": [
{
"name": "digestConfigName",
"actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
"frequency": "P30D",
"frequency": 30,
"categories": [
"HighAvailability",
"Security",
"Performance",
"Cost",
"OperationalExcellence"
],
"language": "en"
"language": "en",
"state": "Active"
}
]
}
}
}
}
}
}
8 changes: 5 additions & 3 deletions ...sor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListConfigurations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,18 @@
"exclude": false,
"digests": [
{
"name": "digestConfigName",
"actionGroupResourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.insights/actionGroups/actionGroupName",
"frequency": "P30D",
"frequency": 30,
"categories": [
"HighAvailability",
"Security",
"Performance",
"Cost",
"OperationalExcellence"
],
"language": "en"
"language": "en",
"state": "Active"
}
]
}
Expand All @@ -36,4 +38,4 @@
}
}
}
}
}