Skip to content

MachineLearningService: changes for serviceProvisionedRG on workspace#8201

Merged
PhoenixHe-NV merged 3 commits intoAzure:masterfrom
DeMale:serviceProvisionedRg
Feb 3, 2020
Merged

MachineLearningService: changes for serviceProvisionedRG on workspace#8201
PhoenixHe-NV merged 3 commits intoAzure:masterfrom
DeMale:serviceProvisionedRg

Conversation

@DeMale
Copy link
Contributor

@DeMale DeMale commented Jan 21, 2020 •
edited
Loading

creation

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@DeMale DeMale requested review from noorabani and zhaomuzhi January 21, 2020 18:51
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 21, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 302411c with merge commit 023e868. SDK Automation 13.0.17.20191226.1
  • ⚠️machinelearningservices/mgmt/2018-11-19 [Logs]  
      No file is changed.
    • ⚠️machinelearningservices/mgmt/2019-05-01 [Logs]  
        No file is changed.
      • ⚠️machinelearningservices/mgmt/2019-06-01 [Logs]  
          No file is changed.
        • ⚠️machinelearningservices/mgmt/2019-11-01 [Logs]  
            No file is changed.
          • ️✔️machinelearningservices/mgmt/2020-01-01 [Logs]  [Release SDK Changes]
          • ⚠️preview/machinelearningservices/mgmt/2018-03-01-preview [Logs]  
              No file is changed.

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jan 21, 2020 •
            edited
            Loading

            azure-sdk-for-java - Release

            No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jan 21, 2020 •
            edited
            Loading

            azure-sdk-for-net - Release

            ️✔️ succeeded [Logs] [Expand Details]
            • ️✔️ Generate from 302411c with merge commit 023e868. SDK Automation 13.0.17.20191226.1 
              [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
            • ️✔️Microsoft.Azure.Management.MachineLearningServices [Logs]  [Release SDK Changes]
                No Artifact Generated.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jan 21, 2020 •
              edited
              Loading

              azure-sdk-for-js - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 302411c with merge commit 023e868. SDK Automation 13.0.17.20191226.1
              • ️✔️@azure/arm-machinelearningservices [Logs]  [Release SDK Changes] 
                [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
[npmPack] created ./dist/arm-machinelearningservices.js in 375ms

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jan 21, 2020 •
              edited
              Loading

              azure-sdk-for-python - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 302411c with merge commit 023e868. SDK Automation 13.0.17.20191226.1
              • ️✔️azure-mgmt-machinelearningservices [Logs]  [Release SDK Changes] 
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

              This was referenced Jan 21, 2020
              Closed
              Closed
              Closed
              zhaomuzhi
              zhaomuzhi approved these changes Jan 21, 2020
              View reviewed changes
              ...rce-manager/Microsoft.MachineLearningServices/stable/2020-01-01/machineLearningServices.json Outdated
              Copy link
              Contributor

              @zhaomuzhi zhaomuzhi Jan 21, 2020

              Choose a reason for hiding this comment

              The reason will be displayed to describe this comment to others. Learn more.

              Change to "The name of the scoped resource group created by workspace RP in customer subscription if the workspace is cmk workspace"?

              @azure-pipelines
              Copy link

              azure-pipelines bot commented Jan 21, 2020

              Azure Pipelines successfully started running 1 pipeline(s).

              @PhoenixHe-NV
              Copy link

              PhoenixHe-NV commented Jan 22, 2020

              /azp run automation - sdk

              @azure-pipelines
              Copy link

              azure-pipelines bot commented Jan 22, 2020

              Azure Pipelines successfully started running 1 pipeline(s).

              @PhoenixHe-NV
              Copy link

              PhoenixHe-NV commented Jan 22, 2020

              @DeMale Please fix the prettier following https://aka.ms/AA6h31t

              @azure-pipelines
              Copy link

              azure-pipelines bot commented Jan 22, 2020

              Azure Pipelines successfully started running 1 pipeline(s).

              @PhoenixHe-NV
              Copy link

              PhoenixHe-NV commented Feb 3, 2020

              /azp run automation - sdk

              @PhoenixHe-NV
              Copy link

              PhoenixHe-NV commented Feb 3, 2020

              @DeMale Is this PR ready for merge?

              @azure-pipelines
              Copy link

              azure-pipelines bot commented Feb 3, 2020

              Azure Pipelines successfully started running 1 pipeline(s).

              @DeMale
              Copy link
              Contributor Author

              DeMale commented Feb 3, 2020 via email

              @PhoenixHe-NV PhoenixHe-NV merged commit 023e868 into Azure:master Feb 3, 2020
              ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
              @DeMale @ssripadham
              MachineLearningService: changes for serviceProvisionedRG on workspace (…
              994337a 
              …Azure#8201)

* MachineLearningService: changes for serviceProvisionedRG on workspace
creation

* PR changes

* fixed prettier
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              @DeMale @00Kai0
              MachineLearningService: changes for serviceProvisionedRG on workspace (…
              3491842 
              …Azure#8201)

* MachineLearningService: changes for serviceProvisionedRG on workspace
creation

* PR changes

* fixed prettier
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Reviewers

              @noorabani noorabani noorabani approved these changes

              +2 more reviewers

              @PhoenixHe-NV PhoenixHe-NV PhoenixHe-NV approved these changes

              @zhaomuzhi zhaomuzhi zhaomuzhi approved these changes

              Reviewers whose approvals may not affect merge requirements

              Assignees

              @PhoenixHe-NV PhoenixHe-NV

              Labels

              None yet

              Projects

              None yet

              Milestone

              No milestone

              Development

              Successfully merging this pull request may close these issues.

              4 participants

              @DeMale @PhoenixHe-NV @zhaomuzhi @noorabani

              Comments