Adding new version to marketplace resource by olrakovs-zz · Pull Request #8191 · Azure/azure-rest-api-specs

olrakovs-zz · 2020-01-19T18:18:37Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-01-19T18:18:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T18:25:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T19:12:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T19:25:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T20:21:38Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-19T20:23:13Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-19T20:23:13Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-19T20:23:17Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-19T20:23:18Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-19T20:23:20Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-01-19T20:32:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T20:33:01Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T20:33:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-19T20:33:17Z

Azure Pipelines successfully started running 1 pipeline(s).

noamben

please fix all comments before completing

sanjaiganesh · 2020-01-20T17:19:01Z

+  "schemes": [
+    "https"
+  ],
+  "paths": {


paths [](start = 3, length = 5)

which of these resources are ARM tracked resources ? (routing type=manifest. ?
For all those, PATCH must be defined, with support for patching at least 'tags'.

Could you please create manifest ARM manifest PR as well ?
(repo: https://armmanifest.visualstudio.com/One/_git/Manifest)

it will be tenant proxy no arm track

azure-pipelines · 2020-01-20T18:28:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-20T18:29:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-20T18:49:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-20T18:56:30Z

Azure Pipelines successfully started running 1 pipeline(s).

sanjaiganesh · 2020-01-20T20:00:42Z

+            "in": "body",
+            "name": "payload",
+            "schema": {
+              "$ref": "#/definitions/OfferUpdateProperties"


OfferUpdateProperties [](start = 37, length = 21)

remove OfferUpdateProperties and use Offer itself

weidongxu-microsoft · 2020-01-21T02:53:26Z

@olrakovs
You still need to pass PrettierCheck.

Let me know if you are ready to merge.

azure-pipelines · 2020-01-21T08:22:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-21T09:36:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-21T10:13:08Z

Azure Pipelines successfully started running 1 pipeline(s).

olrakovs-zz · 2020-01-21T10:25:25Z

@weidongxu-microsoft I am ready to merge!

olrakovs added 3 commits January 19, 2020 13:41

add new resource private store

aa9f696

Adding get examples

41c728b

adding empty line

d6085aa

olrakovs-zz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 19, 2020

openapi-assignment-bot Bot assigned weidongxu-microsoft Jan 19, 2020

spelling fix

e5075fb

olrakovs-zz added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jan 19, 2020

Prettier files

24b870a

fixing model

22921a4

noamben reviewed Jan 19, 2020

View reviewed changes

adding files to readme.md

b3b5d4e

noamben reviewed Jan 19, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

noferrar reviewed Jan 19, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

noferrar reviewed Jan 19, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

noamben approved these changes Jan 19, 2020

View reviewed changes

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json Outdated

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json

second itration of comments

c0c7e97

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

Comment thread ...cation/marketplace/resource-manager/Microsoft.Marketplace/stable/2020-01-01/Marketplace.json

another fix

9b67a48

new out examples

913669f

model vaiadtion fix

ba024a3

sanjaiganesh reviewed Jan 20, 2020

View reviewed changes

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 20, 2020

weidongxu-microsoft approved these changes Jan 21, 2020

View reviewed changes

olrakovs added 2 commits January 21, 2020 10:20

change object

4aada49

message

28d520d

prettier

9d07ff5

prttier

7103f3e

weidongxu-microsoft merged commit a1c9f5e into Azure:master Jan 22, 2020

Conversation

olrakovs-zz commented Jan 19, 2020 • edited by noamben Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

openapi-sdkautomation Bot commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

Uh oh!

noamben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sanjaiganesh Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

noamben Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 20, 2020

Uh oh!

azure-pipelines Bot commented Jan 20, 2020

Uh oh!

azure-pipelines Bot commented Jan 20, 2020

Uh oh!

olrakovs-zz commented Jan 19, 2020 •

edited by noamben

Loading

openapi-sdkautomation Bot commented Jan 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 19, 2020 •

edited

Loading

weidongxu-microsoft commented Jan 21, 2020 •

edited

Loading