Add new ANF API 2019-11-01 by leonardbf · Pull Request #8164 · Azure/azure-rest-api-specs

leonardbf · 2020-01-15T13:17:50Z

Removal of mount target list operation and change to response properties.
Addition of site property.
Removal of snapshot tags property.
Add missing revert volume to snapshot.
Amend property in authorize example.
Other minor amendments.
(Internal ticket ANF-567)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

ANF-567 add API 2019-11-01

azure-pipelines · 2020-01-15T13:18:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Prettier

azure-pipelines · 2020-01-15T15:04:29Z

Azure Pipelines successfully started running 1 pipeline(s).

leonardbf · 2020-01-15T17:14:11Z

@iscai-msft you were a suggested reviewer but I also have a question. I'm wondering why the pipeline shows some checks were not successful even though no steps actually show as failed. Do you know why this is? One does show as cancelled. Do you know why this one is cancelled?

ANF-567 add API 2019-11-01

azure-pipelines · 2020-01-17T09:52:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-17T09:53:16Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-17T09:54:25Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from dbeec79 with merge commit 145ff62. SDK Automation 13.0.17.20191226.1
️✔️netapp/mgmt/2019-05-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-05-01.zip
️✔️netapp/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-06-01.zip
️✔️netapp/mgmt/2019-07-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-07-01.zip
️✔️netapp/mgmt/2019-08-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-08-01.zip
️✔️netapp/mgmt/2019-10-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-10-01.zip
️✔️netapp/mgmt/2019-11-01 [Logs] [Release SDK Changes]
- netapp.mgmt.2019-11-01.zip
️✔️preview/netapp/mgmt/2017-08-15 [Logs] [Release SDK Changes]
- preview.netapp.mgmt.2017-08-15.zip

openapi-sdkautomation · 2020-01-17T09:54:32Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from dbeec79 with merge commit 145ff62. SDK Automation 13.0.17.20191226.1
️✔️sdk/netapp/mgmt-v2017_08_15 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_05_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_06_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_07_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_08_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_10_01 [Logs] [Release SDK Changes]
️✔️sdk/netapp/mgmt-v2019_11_01 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-01-17T09:54:38Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from dbeec79 with merge commit 145ff62. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.NetApp [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.NetApp.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=netapp /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-01-17T09:54:44Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from dbeec79 with merge commit 145ff62. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-netapp [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-01-17T09:54:47Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from dbeec79 with merge commit 145ff62. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-netapp [Logs] [Release SDK Changes]

azure-arm-netapp-7.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
[npmPack] created ./dist/arm-netapp.js in 384ms

ANF-567 add API 2019-11-01

azure-pipelines · 2020-01-17T09:59:18Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz · 2020-01-22T05:41:42Z

specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-11-01/netapp.json

+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/revert": {
+      "post": {


post [](start = 7, length = 4)

you are missing the x-ms-long-running-operation annotation - please take a look at https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-long-running-operation

Yes. This was also pointed out in the review for the previous swagger which was accepted. We created an open internal ticket on this issue to investigate.

The fact is that adding this results in a failure from the autorest validation 'ERROR (LongRunningResponseStatusCode/R2005/SDKViolation): A 'POST' operation 'Volumes_Revert' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201 or 204.'

But perhaps you have some idea how to solve this?

Yup. Due to limitations of the current version of OpenAPiSpec (aka Swagger), we don't have a good way of modeling the final response on a long running operation (the response on the GET on the async operation URL).

The, somewhat counterintuitive, workaround is to add a 200 response to this path. By convention the code generator will understand that your service is not returning the 200 response for this POST, but that this is the final operation result instead. Does that make sense?

In reply to: 369432464 [](ancestors = 369432464)

So I just need to add a (dummy) 200 response block. I'll update.

@majastrz Update made. But I notice some validation checks did not run.

majastrz

Please take a look at the comment I added.

Correct long running operations - add dummy terminal 200 state

ANF-567 add new API 2019-11-01

azure-pipelines · 2020-01-23T10:15:25Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz

Signed off from ARM side.

majastrz · 2020-01-24T03:27:20Z

@NullMDR any idea why some of the checks got cancelled? How do we restart them?

PhoenixHe-NV · 2020-01-24T05:25:47Z

/azp run automation - sdk

azure-pipelines · 2020-01-24T05:25:57Z

Azure Pipelines successfully started running 1 pipeline(s).

leonardbf · 2020-01-24T07:46:13Z

Any chance this could be merged? I see there is a failure however but it seems to be a problem of the job not the swagger "Failed to run SDK Automation: Error: SDK Automation failed"

* ANF-567 add API 2019-11-01 * ANF-567 add API 2019-11-01 * Update netapp.json Prettier * ANF-567 add API 2019-11-01 * ANF-567 add API 2019-11-01 * ANF-567 add new API 2019-11-01 Correct long running operations - add dummy terminal 200 state

leonardbf and others added 4 commits January 15, 2020 12:47

ANF-567 add API 2019-11-01

a5c2b49

Merge pull request #44 from leonardbf/ANF-567-add-API-2019-11-01

e5548bf

ANF-567 add API 2019-11-01

ANF-567 add API 2019-11-01

f7d2d9b

Merge pull request #45 from leonardbf/ANF-567-add-API-2019-11-01

00f669b

ANF-567 add API 2019-11-01

openapi-assignment-bot bot assigned PhoenixHe-NV Jan 15, 2020

Update netapp.json

1fc9708

Prettier

leonardbf and others added 2 commits January 17, 2020 09:50

ANF-567 add API 2019-11-01

f868b77

Merge pull request #46 from leonardbf/ANF-567-add-API-2019-11-01

f78bc95

ANF-567 add API 2019-11-01

This was referenced Jan 17, 2020

[AutoPR @azure/arm-netapp] Add new ANF API 2019-11-01 AzureSDKAutomation/azure-sdk-for-js#274

Closed

[AutoPR azure-mgmt-netapp] Add new ANF API 2019-11-01 AzureSDKAutomation/azure-sdk-for-python#218

Closed

ANF-567 add API 2019-11-01

087483e

openapi-sdkautomation bot mentioned this pull request Jan 17, 2020

[AutoPR Microsoft.Azure.Management.NetApp] Add new ANF API 2019-11-01 AzureSDKAutomation/azure-sdk-for-net#336

Closed

Merge pull request #47 from leonardbf/ANF-567-add-API-2019-11-01

1458c66

ANF-567 add API 2019-11-01

openapi-sdkautomation bot mentioned this pull request Jan 17, 2020

[AutoPR sdk/netapp/mgmt-v2017_08_15] Add new ANF API 2019-11-01 AzureSDKAutomation/azure-sdk-for-java#720

Closed

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 17, 2020

majastrz reviewed Jan 22, 2020

View reviewed changes

majastrz added the ARMChangesRequested label Jan 22, 2020

majastrz requested changes Jan 22, 2020

View reviewed changes

ANF-567 add new API 2019-11-01

7ad7631

Correct long running operations - add dummy terminal 200 state

Merge pull request #48 from leonardbf/ANF-567-add-API-2019-11-01

dbeec79

ANF-567 add new API 2019-11-01

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 24, 2020

majastrz approved these changes Jan 24, 2020

View reviewed changes

PhoenixHe-NV merged commit 145ff62 into Azure:master Jan 24, 2020

Conversation

leonardbf commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Jan 15, 2020

Uh oh!

azure-pipelines bot commented Jan 15, 2020

Uh oh!

leonardbf commented Jan 15, 2020

Uh oh!

azure-pipelines bot commented Jan 17, 2020

Uh oh!

azure-pipelines bot commented Jan 17, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

azure-pipelines bot commented Jan 17, 2020

Uh oh!

majastrz Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

leonardbf Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

majastrz Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

leonardbf Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

leonardbf Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jan 23, 2020

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

majastrz commented Jan 24, 2020

Uh oh!

PhoenixHe-NV commented Jan 24, 2020

Uh oh!

azure-pipelines bot commented Jan 24, 2020

Uh oh!

leonardbf commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leonardbf commented Jan 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 17, 2020 •

edited

Loading