Skip to content

Add new api-version 2019-06-15 of recoveryservicebackup for go sdk#8160

Merged
allenjzhang merged 1 commit intoAzure:masterfrom
ArcturusZhang:add-new-api-version-for-recoveryservice-backup
Jan 21, 2020
Merged

Add new api-version 2019-06-15 of recoveryservicebackup for go sdk#8160
allenjzhang merged 1 commit intoAzure:masterfrom
ArcturusZhang:add-new-api-version-for-recoveryservice-backup

Conversation

@ArcturusZhang
Copy link
Copy Markdown
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@allenjzhang
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 15, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 15, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 11f0576 with merge commit e61f973. SDK Automation 13.0.17.20191226.1
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 15, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 15, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jan 15, 2020

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 11f0576 with merge commit e61f973. SDK Automation 13.0.17.20191226.1
    Failed to find any diff after autorest so no changed packages was found.

@ArcturusZhang
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).


``` yaml $(go) && $(multiapi)
batch:
- tag: package-2019-06
Copy link
Copy Markdown
Contributor

@allenjzhang allenjzhang Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArcturusZhang Any reason that Java version is not updated as well. Looks like Java is lagging behind for quite a few package versions.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added on demand. This api-version is requested by an email request, when I am releasing the go SDK, I noticed that the go config file does not have this api-version, therefore i added this one in this PR.
I suppose the java SDK owner will spot the same problem and submit his own PR for java new api-version when he is releasing the java SDK for the same request

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, can you send an email and notify respective SDK owners? Thanks.

@ArcturusZhang ArcturusZhang changed the title Add new api-version 2019-06-15 for go sdk Add new api-version 2019-06-15 of recoveryservicebackup for go sdk Jan 16, 2020
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@allenjzhang allenjzhang merged commit e61f973 into Azure:master Jan 21, 2020
@ArcturusZhang ArcturusZhang deleted the add-new-api-version-for-recoveryservice-backup branch January 22, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants