Skip to content

Comments

adding LogicAppResourceId to Action request and response #8144

Merged
allenjzhang merged 13 commits intoAzure:masterfrom
ori-licht:master
Jan 27, 2020
Merged

adding LogicAppResourceId to Action request and response #8144
allenjzhang merged 13 commits intoAzure:masterfrom
ori-licht:master

Conversation

@ori-licht
Copy link
Contributor

@ori-licht ori-licht commented Jan 14, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jan 14, 2020

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht
Copy link
Contributor Author

ori-licht commented Jan 14, 2020

need to make another iteration

@ori-licht ori-licht reopened this Jan 14, 2020
@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht ori-licht reopened this Jan 14, 2020
@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht ori-licht reopened this Jan 14, 2020
@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht ori-licht reopened this Jan 14, 2020
@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht ori-licht reopened this Jan 14, 2020
@ori-licht ori-licht closed this Jan 14, 2020
@ori-licht ori-licht reopened this Jan 14, 2020
@allenjzhang
Copy link
Contributor

allenjzhang commented Jan 15, 2020

/azp run

@allenjzhang allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 15, 2020
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 15, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 15, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 15, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from d0e4501 with merge commit ab608e1. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 15, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from d0e4501 with merge commit ab608e1. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 15, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 15, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from d0e4501 with merge commit ab608e1. SDK Automation 13.0.17.20191226.1 
      Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rule_templates_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmark_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmarks_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_aggregations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entities_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entity_queries_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_office_consents_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_product_settings_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_security_insights_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 15, 2020
    Closed
    @majastrz
    Copy link
    Member

    majastrz commented Jan 21, 2020 

              "$ref": "#/definitions/ActionResponse"

    You are effectively adding a required property to a PUT. This will break existing SDKs. These types of changes should be introduced in a new API version.

    Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json:413 in 487ed36. [](commit_id = 487ed36, deletion_comment = False)

    majastrz
    majastrz requested changes Jan 21, 2020
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added a comment about breaking changes. Please take a look.

    @ori-licht ori-licht closed this Jan 22, 2020
    @ori-licht ori-licht reopened this Jan 22, 2020
    @ori-licht ori-licht requested a review from majastrz January 22, 2020 10:16
    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 22, 2020
    majastrz
    majastrz approved these changes Jan 22, 2020
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @ori-licht
    Copy link
    Contributor Author

    ori-licht commented Jan 23, 2020

    removed the required

    @allenjzhang
    Copy link
    Contributor

    allenjzhang commented Jan 23, 2020

    /azp run

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 23, 2020

    Azure Pipelines successfully started running 3 pipeline(s).

    @allenjzhang
    Copy link
    Contributor

    allenjzhang commented Jan 27, 2020

    /azp run

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 27, 2020

    Azure Pipelines successfully started running 3 pipeline(s).

    @allenjzhang allenjzhang merged commit ab608e1 into Azure:master Jan 27, 2020
    ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
    @ori-licht @ssripadham
    adding LogicAppResourceId to Action request and response (Azure#8144)
    1d6cb56 
    * update swagger - aading LogicAppResourceId to Action put and response

* update swagger - changing to logicAppResourceId style

* adding LogicAppResourceId to Actions Request & Response

* adding LogicAppResourceId to Actions Request & Response

* adding Action property base

* editing examples and adding reauired to logicAppResourceId

* from LogicAppResourceId to logicAppResourceId

* running prettier

* running prettier

* removing required for LogicAppRexourceId

*  changing logicApp propery doc

*  changing logicApp propery description
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @ori-licht @00Kai0
    adding LogicAppResourceId to Action request and response (Azure#8144)
    8b3d7ab 
    * update swagger - aading LogicAppResourceId to Action put and response

* update swagger - changing to logicAppResourceId style

* adding LogicAppResourceId to Actions Request & Response

* adding LogicAppResourceId to Actions Request & Response

* adding Action property base

* editing examples and adding reauired to logicAppResourceId

* from LogicAppResourceId to logicAppResourceId

* running prettier

* running prettier

* removing required for LogicAppRexourceId

*  changing logicApp propery doc

*  changing logicApp propery description
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @majastrz majastrz majastrz approved these changes

    +1 more reviewer

    @allenjzhang allenjzhang allenjzhang approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @allenjzhang allenjzhang

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @ori-licht @AutorestCI @allenjzhang @majastrz