Operational insights data export by hohershk · Pull Request #8128 · Azure/azure-rest-api-specs

hohershk · 2020-01-12T14:25:56Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2020-01-12T14:25:58Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

This reverts commit a23f53b.

This reverts commit f39f5e4.

This reverts commit 50cf6aa.

azuresdkci · 2020-01-13T15:22:05Z

Can one of the admins verify this patch?

azure-pipelines · 2020-01-14T11:44:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-14T11:44:45Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-14T12:16:07Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4b4fb81 with merge commit b3def49. SDK Automation 13.0.17.20191226.1
️✔️operationalinsights/mgmt/2015-03-20 [Logs] [Release SDK Changes]
- operationalinsights.mgmt.2015-03-20.zip
️✔️preview/operationalinsights/mgmt/2015-11-01-preview [Logs] [Release SDK Changes]
- preview.operationalinsights.mgmt.2015-11-01-preview.zip

openapi-sdkautomation · 2020-01-14T12:16:08Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-14T12:16:08Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4b4fb81 with merge commit b3def49. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-operationalinsights [Logs] [Release SDK Changes]

azure-arm-operationalinsights-1.2.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/operationalInsightsManagementClient.js → ./dist/arm-operationalinsights.js...
[npmPack] created ./dist/arm-operationalinsights.js in 260ms

openapi-sdkautomation · 2020-01-14T12:16:21Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4b4fb81 with merge commit b3def49. SDK Automation 13.0.17.20191226.1
️✔️azure-mgmt-loganalytics [Logs] [Release SDK Changes]
- azure-mgmt-loganalytics-0.2.0.zip
- azure_mgmt_loganalytics-0.2.0-py2.py3-none-any.whl

openapi-sdkautomation · 2020-01-14T12:16:24Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4b4fb81 with merge commit b3def49. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.OperationalInsights [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.OperationalInsights.0.19.0-preview.nupkg
- Microsoft.Azure.Management.OperationalInsights.0.19.0-preview.snupkg

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json

sanjaiganesh · 2020-01-15T23:05:37Z

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json

+    },
+    "DataExportProperties": {
+      "properties": {
+        "dataExportId": {


dataExportId [](start = 9, length = 12)

If this is a fixed set, consider defining as enum and modelAsString=true for flexibility to add a new one without breaking clients

It's not a fixed set. It a unique guid generator identifier

sanjaiganesh · 2020-01-15T23:09:19Z

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json

+            "StorageAccount",
+            "EventHub"
+          ]
+        },


i suppose type can be derived from the resourceId..

Also, you may consider making destination as an array if you envision supporting export to multiple destinations

We want the type explicitly to avoid customer's mistakes.
It we will always one destination to export.

sanjaiganesh · 2020-01-15T23:10:04Z

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json

+      "properties": {
+        "eventHubName": {
+          "type": "string",
+          "description": "event hub name."


isn't this evident from the resourceId provided .. ?

No, Event hub is tracked resource. His main resource is namespace.
it's the same scenario like diagnostic settings.

azure-pipelines · 2020-01-16T12:52:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-16T13:22:35Z

Azure Pipelines successfully started running 1 pipeline(s).

…hohershk/azure-rest-api-specs into OperationalInsights_data_export

azure-pipelines · 2020-01-19T13:38:48Z

Azure Pipelines successfully started running 1 pipeline(s).

zikalino · 2020-01-27T11:05:14Z

/azp run

azure-pipelines · 2020-01-27T11:05:40Z

Azure Pipelines successfully started running 3 pipeline(s).

* microsoft.operationalinsights_add_data_export * fix * fix * fix readmfile + fix cSpell * fix * Revert "fix" This reverts commit a23f53b. * Fix azure-rest-api-specs-tests * format * Revert "format" This reverts commit f39f5e4. * Revert "Fix azure-rest-api-specs-tests" This reverts commit 50cf6aa. * prettifer * Code review fixes * Update OperationalInsights.json * Make Destination type "readonly" Co-authored-by: Arik Olsh <47111029+arolshan@users.noreply.github.com>

hohershk added 3 commits January 12, 2020 15:28

microsoft.operationalinsights_add_data_export

6b543ce

fix

4d0c28d

fix

3d16a91

openapi-assignment-bot bot assigned zikalino Jan 12, 2020

hohershk and others added 8 commits January 13, 2020 09:01

fix readmfile + fix cSpell

94e47a2

fix

a23f53b

Revert "fix"

30f830a

This reverts commit a23f53b.

Fix azure-rest-api-specs-tests

50cf6aa

format

f39f5e4

Revert "format"

734f84c

This reverts commit f39f5e4.

Revert "Fix azure-rest-api-specs-tests"

da709ed

This reverts commit 50cf6aa.

prettifer

554fb5a

arolshan requested a review from KrisBash January 13, 2020 09:14

sanjaiganesh reviewed Jan 15, 2020

View reviewed changes

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json Show resolved Hide resolved

sanjaiganesh reviewed Jan 15, 2020

View reviewed changes

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json Outdated Show resolved Hide resolved

sanjaiganesh reviewed Jan 15, 2020

View reviewed changes

sanjaiganesh added ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2020

Code review fixes

32e6107

Update OperationalInsights.json

1692ea3

hohershk added 2 commits January 19, 2020 15:33

Make Destination type "readonly"

756a31e

Merge branch 'OperationalInsights_data_export' of https://github.com/…

4b4fb81

…hohershk/azure-rest-api-specs into OperationalInsights_data_export

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 20, 2020

zikalino approved these changes Jan 27, 2020

View reviewed changes

zikalino merged commit b3def49 into Azure:master Jan 27, 2020

Conversation

hohershk commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Jan 12, 2020

Uh oh!

azuresdkci commented Jan 13, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

Uh oh!

Uh oh!

sanjaiganesh Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

hohershk Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

hohershk Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

hohershk Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

azure-pipelines bot commented Jan 19, 2020

Uh oh!

zikalino commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hohershk commented Jan 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

hohershk Jan 16, 2020 •

edited

Loading