Skip to content

Update readme.md #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lirenhe merged 2 commits into from
Jan 15, 2020
Merged

Update readme.md #8118

lirenhe merged 2 commits into from
Jan 15, 2020

Conversation

@jikuma
Copy link
Contributor

@jikuma jikuma commented Jan 10, 2020

Change default package version for container registry sdk.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 10, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 714b53d with merge commit 1e590d7. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-containerregistry [Logs]  [Release SDK Changes] 
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01-preview', '2019-05-01'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 714b53d with merge commit 1e590d7. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-containerregistry [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
[npmPack] created ./dist/arm-containerregistry.js in 642ms

This was referenced Jan 10, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@lirenhe
Copy link
Member

lirenhe commented Jan 10, 2020

@jikuma, could you take a look at the issue in SDK JavaScript

@jikuma
Copy link
Contributor Author

jikuma commented Jan 10, 2020

@jikuma, could you take a look at the issue in SDK JavaScript

From the error, I can make out that it's failing because of incompatible api version 2019-12-01-preview and 2019-05-01. But why is it taking two api version while generating javascript sdk? I verified that swagger file has only one api-version as an argument?

@azuresdkci
Copy link
Contributor

azuresdkci commented Jan 13, 2020

Can one of the admins verify this patch?

@qiaozha
Copy link
Member

qiaozha commented Jan 14, 2020

@jikuma in your readme.typescript.md you have extra input files which cause the error, any particular reason why put these three file in typescript sdk? if no particular reason, please check whether these three file is what you want? if yes, please check whether there's duplicate definition among these files and your default tag input files. if no, please remove them in readme.typescript.md

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 14, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 14, 2020
Closed
@lirenhe lirenhe merged commit 1e590d7 into master Jan 15, 2020
@JackTn JackTn deleted the users/jikuma/updating-default-package-version branch August 9, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lirenhe lirenhe lirenhe approved these changes

+1 more reviewer

@ankurkhemani ankurkhemani ankurkhemani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lirenhe lirenhe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jikuma @lirenhe @azuresdkci @qiaozha @ankurkhemani