[Hub Generated] Review request for Microsoft.DigitalTwins to add version preview/2020-03-01-preview by sup-s · Pull Request #8114 · Azure/azure-rest-api-specs

sup-s · 2020-01-09T20:30:07Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azure-pipelines · 2020-01-09T20:30:26Z

Azure Pipelines successfully started running 1 pipeline(s).

sup-s · 2020-01-09T20:31:00Z

The swagger has been approved by ARM in the private repo. See: Azure/azure-rest-api-specs-pr#999.
In this PR, I have

Changed API version to 2020-03-01-preview (was: 2020-02-26-preview)
Addressed feedback on private repo PR.

openapi-sdkautomation · 2020-01-09T20:31:58Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from dec2f60 with merge commit bbc1fea. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-01-09T20:32:02Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from dec2f60 with merge commit bbc1fea. SDK Automation 13.0.17.20191226.1
️✔️preview/digitaltwins/mgmt/2020-03-01-preview [Logs] [Release SDK Changes]
- preview.digitaltwins.mgmt.2020-03-01-preview.zip

openapi-sdkautomation · 2020-01-09T20:32:05Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-09T20:32:05Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from dec2f60 with merge commit bbc1fea. SDK Automation 13.0.17.20191226.1

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/_azure_digital_twins_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/models/_azure_digital_twins_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/_digital_twins_endpoint_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/_digital_twins_io_thubs_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/_digital_twins_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/_io_thub_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/digitaltwins/version.py

openapi-sdkautomation · 2020-01-09T20:32:05Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from dec2f60 with merge commit bbc1fea. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

azure-pipelines · 2020-01-10T21:17:01Z

Azure Pipelines successfully started running 1 pipeline(s).

ryansbenson

Approved from ARMs side

ArcturusZhang · 2020-01-13T04:50:22Z

specification/digitaltwins/resource-manager/readme.go.md

+Please also specify `--go-sdks-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+```yaml $(tag) == 'package-2020-03-01-preview' && $(go)
+namespace: Microsoft.DigitalTwins


Please change this to digitaltwins

The namespace should be digitaltwins, please change the namespace.

specification/digitaltwins/resource-manager/readme.go.md

azuresdkci · 2020-01-13T15:22:22Z

Can one of the admins verify this patch?

azure-pipelines · 2020-01-13T18:47:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-14T05:32:40Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-01-14T05:49:50Z

specification/digitaltwins/resource-manager/readme.go.md

+Please also specify `--go-sdks-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+```yaml $(tag) == 'package-2020-03-01-preview' && $(go)
+namespace: Microsoft.DigitalTwins


The namespace should be digitaltwins, please change the namespace.

ArcturusZhang · 2020-01-14T05:51:31Z

Hi @sup-s please change the namespace in readme.go.md. Despite the CI is not reporting errors now, the go SDK will not compile when the namespace contains dot or up-case letters.

azure-pipelines · 2020-01-14T06:14:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-14T15:33:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-14T15:33:55Z

Azure Pipelines successfully started running 1 pipeline(s).

sup-s and others added 9 commits January 9, 2020 12:19

New Readme Config File

0f8ad88

New Go Language Readme Config File

11d0247

New Typescript Language Readme Config File

fee2164

New Python Language Readme Config File

b634626

New C# Language Readme Config File

b27ac7e

New Ruby Language Readme Config File

d702b6b

New Swagger Spec File

aff6be8

New Swagger Example Spec File

11f982a

Added DT API

f54289f

openapi-assignment-bot bot assigned erich-wang Jan 9, 2020

sup-s added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 9, 2020

prettier fixes

5a1eacd

ryansbenson reviewed Jan 10, 2020

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2020

erich-wang approved these changes Jan 13, 2020

View reviewed changes

ArcturusZhang requested changes Jan 13, 2020

View reviewed changes

fixing go sdk per comments

08f4fac

java sdk fix

8d2dd17

ArcturusZhang requested changes Jan 14, 2020

View reviewed changes

changing go sdk namespace to digitaltwins

dec2f60

ArcturusZhang approved these changes Jan 14, 2020

View reviewed changes

erich-wang merged commit bbc1fea into Azure:master Jan 15, 2020

Comments

Conversation

sup-s commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

sup-s commented Jan 9, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

azure-pipelines bot commented Jan 10, 2020

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

ArcturusZhang Jan 13, 2020

Choose a reason for hiding this comment

Uh oh!

ArcturusZhang Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azuresdkci commented Jan 13, 2020

Uh oh!

azure-pipelines bot commented Jan 13, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

ArcturusZhang Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

ArcturusZhang commented Jan 14, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

azure-pipelines bot commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sup-s commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading