HybridCompute - Add stable api 2019-12-12 swagger by dkirby017 · Pull Request #8095 · Azure/azure-rest-api-specs

dkirby017 · 2020-01-08T21:28:50Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-01-08T21:29:08Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-08T21:43:30Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1
️✔️sdk/hybridcompute/mgmt-v2019_12_12 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-01-08T21:43:34Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1
️✔️preview/hybridcompute/mgmt/2019-12-12 [Logs] [Release SDK Changes]
- preview.hybridcompute.mgmt.2019-12-12.zip

openapi-sdkautomation · 2020-01-08T21:44:10Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-01-08T21:44:19Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.HybridCompute [Logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-01-08T21:44:30Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 87808a6 with merge commit 53428a5. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-hybridcompute [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

yungezz

pls add missing examples.

azure-pipelines · 2020-01-09T20:35:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T20:47:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T21:54:50Z

Azure Pipelines successfully started running 1 pipeline(s).

ryansbenson

Minor change requested.

azure-pipelines · 2020-01-10T18:14:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-01-13T15:22:50Z

Can one of the admins verify this patch?

yungezz · 2020-01-14T02:23:49Z

hi @dkirby017 could you pls address review comments? let us know when your update done and ready for another review. thanks.

dkirby017 · 2020-01-14T17:31:42Z

@yungezz I did address the comments. Did I miss one?

azure-pipelines · 2020-01-14T17:35:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T16:33:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T18:29:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T19:31:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T20:03:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T20:22:25Z

Azure Pipelines successfully started running 1 pipeline(s).

dkirby017 · 2020-01-15T22:01:07Z

@yungezz @ryansbenson would someone be able to take another look at this now?

azure-pipelines · 2020-01-16T23:52:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-17T21:26:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-17T21:32:53Z

Azure Pipelines successfully started running 1 pipeline(s).

sanjaiganesh · 2020-01-18T00:34:13Z

Adding ARMsignoff. pls add minor comments by Ryan

yungezz · 2020-01-19T01:55:39Z

/azp run

azure-pipelines · 2020-01-19T01:56:03Z

Azure Pipelines successfully started running 3 pipeline(s).

yungezz · 2020-01-19T03:15:45Z

hi @sanjaiganesh 204 response from non-delete operation was deleted already. I'm going to merge this PR if no further comments. add @ryansbenson also.

yungezz · 2020-01-20T02:47:29Z

hi @dkirby017 is this PR ready the merge? is the service public now?

dkirby017 · 2020-01-21T18:22:50Z

@yungezz yes, this PR is ready to merge. we're still in public preview, but it is public rather than private :)

add stable 2019-12-12 swagger

bc51df3

openapi-assignment-bot Bot assigned yungezz Jan 8, 2020

yungezz reviewed Jan 9, 2020

View reviewed changes

Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 9, 2020

David Kirby added 2 commits January 9, 2020 12:34

switch modelAsString to true

479600e

switch modelAsString to true

d137a2c

added missing examples

ee7ac29

add 202 response to example

91bc7b4

ryansbenson reviewed Jan 10, 2020

View reviewed changes

Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated

Comment thread .../hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/HybridCompute.json Outdated

ryansbenson added the ARMChangesRequested label Jan 10, 2020

remove 204 from put and patch

4fe25b3

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

751690e

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

8d71316

fix some example issues

05c5809

fix some more model validation

d7f1d9a

try to run the json through prettier that was flagged

cfb7ac2

ran prettier

b7fa1e9

yungezz reviewed Jan 16, 2020

View reviewed changes

Comment thread ...mpute/resource-manager/Microsoft.HybridCompute/stable/2019-12-12/examples/LISTExtension.json Outdated

dkirby017 added 2 commits January 16, 2020 15:48

add more useful examples for machine resources

e5ecc7b

ran prettier

7ac6f37

add more examples

8355a72

fix examples

87808a6

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 18, 2020

yungezz approved these changes Jan 19, 2020

View reviewed changes

yungezz merged commit 53428a5 into Azure:master Jan 22, 2020

Conversation

dkirby017 commented Jan 8, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Jan 8, 2020

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

yungezz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 9, 2020

Uh oh!

azure-pipelines Bot commented Jan 9, 2020

Uh oh!

azure-pipelines Bot commented Jan 9, 2020

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 10, 2020

Uh oh!

azuresdkci commented Jan 13, 2020

Uh oh!

yungezz commented Jan 14, 2020

Uh oh!

dkirby017 commented Jan 14, 2020

Uh oh!

azure-pipelines Bot commented Jan 14, 2020

Uh oh!

azure-pipelines Bot commented Jan 15, 2020

Uh oh!

azure-pipelines Bot commented Jan 15, 2020

Uh oh!

azure-pipelines Bot commented Jan 15, 2020

Uh oh!

azure-pipelines Bot commented Jan 15, 2020

Uh oh!

azure-pipelines Bot commented Jan 15, 2020

Uh oh!

dkirby017 commented Jan 15, 2020

Uh oh!

Uh oh!

azure-pipelines Bot commented Jan 16, 2020

Uh oh!

azure-pipelines Bot commented Jan 17, 2020

Uh oh!

azure-pipelines Bot commented Jan 17, 2020

Uh oh!

sanjaiganesh commented Jan 18, 2020

Uh oh!

yungezz commented Jan 19, 2020

Uh oh!

azure-pipelines Bot commented Jan 19, 2020

Uh oh!

yungezz commented Jan 19, 2020

Uh oh!

openapi-sdkautomation Bot commented Jan 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 8, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Jan 8, 2020 •

edited

Loading