Skip to content

Comments

Add incidents API to swagger#8077

Merged
raych1 merged 4 commits intoAzure:masterfrom
ityankel:incidentsApi
Jan 30, 2020
Merged

Add incidents API to swagger#8077
raych1 merged 4 commits intoAzure:masterfrom
ityankel:incidentsApi

Conversation

@ityankel
Copy link
Contributor

@ityankel ityankel commented Jan 7, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 7, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 75a73a9 with merge commit 83f4422. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 7, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 7, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 75a73a9 with merge commit 83f4422. SDK Automation 13.0.17.20191226.1 
      Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rule_templates_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmark_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmarks_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_aggregations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entities_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entities_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entity_queries_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entity_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_incident_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_incident_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_incidents_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_office_consents_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_product_settings_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_security_insights_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 7, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 7, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 75a73a9 with merge commit 83f4422. SDK Automation 13.0.17.20191226.1 
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 7, 2020
    Closed
    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 7, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @ityankel ityankel marked this pull request as ready for review January 7, 2020 16:08
    @raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 8, 2020
    @azuresdkci
    Copy link
    Contributor

    azuresdkci commented Jan 13, 2020

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 14, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    sanjaiganesh
    sanjaiganesh reviewed Jan 17, 2020
    View reviewed changes
    ...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated
    Copy link
    Contributor

    @sanjaiganesh sanjaiganesh Jan 17, 2020 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Incidents_List [](start = 24, length = 14)

    ListByWorkspace

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 23, 2020
    @sanjaiganesh
    Copy link
    Contributor

    sanjaiganesh commented Jan 23, 2020

    Discussed offline.. they are not long running, as they complete < 2 sec.
    Please address tabs->to->spaces.
    Please update operationId for all operations, in another PR as discussed.

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 23, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 23, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1
    Copy link
    Member

    raych1 commented Jan 30, 2020

    /azp run automation - sdk

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 30, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1 raych1 merged commit 83f4422 into Azure:master Jan 30, 2020
    ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
    @ityankel @ssripadham
    Add incidents API to swagger (Azure#8077)
    c8cdfcd 
    * Add incidents API to swagger

* Replace tabs with spaces

* Fix failed prettier test
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @ityankel @00Kai0
    Add incidents API to swagger (Azure#8077)
    5b38b2f 
    * Add incidents API to swagger

* Replace tabs with spaces

* Fix failed prettier test
    @ityankel ityankel deleted the incidentsApi branch November 17, 2020 12:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @ryansbenson ryansbenson ryansbenson left review comments

    @raych1 raych1 raych1 approved these changes

    +1 more reviewer

    @sanjaiganesh sanjaiganesh sanjaiganesh left review comments

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @raych1 raych1

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @ityankel @azuresdkci @sanjaiganesh @raych1 @ryansbenson