Skip to content

Comments

fix #7557: update next steps in readme.md#8049

Merged
mozehgir merged 1 commit intomasterfrom
yungez-md
Jan 14, 2020
Merged

fix #7557: update next steps in readme.md#8049
mozehgir merged 1 commit intomasterfrom
yungez-md

Conversation

@yungezz
Copy link
Member

@yungezz yungezz commented Jan 2, 2020

Latest improvements:

next steps link in readme.md is in private repo adx-documentation-pr, which is for microsoft employee only. Update readme.md for confusion on access issue. Readme.md should be refined to include external process when external contriubtion process clearly defined.

Fix issue #7557

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yungezz yungezz changed the title update next steps in readme.md fix #7557: update next steps in readme.md Jan 2, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 2, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 2, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 2, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 2, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 2, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@mozehgir
Copy link
Contributor

mozehgir commented Jan 8, 2020

Hey @yungezz. The "Next Steps" section is for after a swagger is reviewed and merged. Not sure if we need to have this step for external contributors.
I had included a next steps for external contributors under the "Getting Started" section.

@yungezz
Copy link
Member Author

yungezz commented Jan 8, 2020

thanks @mozehgir for clarification. So does change in this PR make sense?

@mozehgir mozehgir merged commit 0d193a3 into master Jan 14, 2020
@JackTn JackTn deleted the yungez-md branch August 9, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants