[Microsoft.Billing] Add billing instructions API. by wilcobmsft · Pull Request #8045 · Azure/azure-rest-api-specs

wilcobmsft · 2019-12-30T21:38:31Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-12-30T21:38:38Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-30T21:38:48Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-30T21:40:39Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 01ef4a8 with merge commit 976254f. SDK Automation 13.0.17.20191226.1
️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]

⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2019-12-30T21:40:40Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 01ef4a8 with merge commit 976254f. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-billing [Logs] [Release SDK Changes]

azure-arm-billing-2.2.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 739ms

openapi-sdkautomation · 2019-12-30T21:40:41Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 01ef4a8 with merge commit 976254f. SDK Automation 13.0.17.20191226.1
⚠️preview/billing/mgmt/2017-02-27-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2017-04-24-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-11-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2019-12-30T21:40:46Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 01ef4a8 with merge commit 976254f. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-billing [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2019-12-30T21:40:49Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 01ef4a8 with merge commit 976254f. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Billing.3.0.0-preview.nupkg
- Microsoft.Azure.Management.Billing.3.0.0-preview.snupkg

azure-pipelines · 2019-12-30T21:41:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T21:44:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T21:53:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T22:00:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T22:22:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T22:53:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:07:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:07:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:07:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:07:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:08:00Z

Azure Pipelines successfully started running 1 pipeline(s).

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

azure-pipelines · 2019-12-31T02:33:18Z

Azure Pipelines successfully started running 1 pipeline(s).

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

anthony-c-martin · 2020-01-02T20:49:57Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

+      }
+    },
+    "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/billingInstructions/{billingInstructionName}": {
+      "get": {


Does this support DELETE?

Not at this time, no. Eventually we may add support for soft-deletes, but that's out-of-scope for now.

Discussed offline. DELETE support will be added when ready, but I'm signing off regardless to unblock testing.

azure-pipelines · 2020-01-02T20:57:04Z

Azure Pipelines successfully started running 1 pipeline(s).

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

azure-pipelines · 2020-01-02T21:13:19Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2020-01-03T01:16:47Z

@anthony-c-martin , you requested the changes. Can you please approve this PR?

anthony-c-martin · 2020-01-03T18:07:38Z

@anthony-c-martin , you requested the changes. Can you please approve this PR?

Oops, I've approved

…ion preview/2022-07-01-preview (#8045) * Microsoft.StorageMover add 200 response code to Delete operations (#8010) * Microsoft.StorageMover - Make parent of required properties also required (#8034) * Update examples

…ion preview/2022-07-01-preview (#8045) (#19992) * Microsoft.StorageMover add 200 response code to Delete operations (#8010) * Microsoft.StorageMover - Make parent of required properties also required (#8034) * Update examples

azuresdkci assigned raych1 Dec 30, 2019

azuresdkci requested a review from raych1 December 30, 2019 21:39

wilcobmsft force-pushed the wilcob/billingInstructions branch from 3536593 to 48725e5 Compare December 30, 2019 21:41

wilcobmsft force-pushed the wilcob/billingInstructions branch from 48725e5 to 24c80c0 Compare December 30, 2019 21:43

wilcobmsft force-pushed the wilcob/billingInstructions branch from 24c80c0 to 449b82a Compare December 30, 2019 21:53

This was referenced Dec 30, 2019

[AutoPR @azure/arm-billing] [Microsoft.Billing] Add billing instructions API. AzureSDKAutomation/azure-sdk-for-js#190

Closed

[AutoPR azure-mgmt-billing] [Microsoft.Billing] Add billing instructions API. AzureSDKAutomation/azure-sdk-for-python#154

Closed

wilcobmsft force-pushed the wilcob/billingInstructions branch from 449b82a to 95f0738 Compare December 30, 2019 22:00

wilcobmsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 30, 2019

wilcobmsft force-pushed the wilcob/billingInstructions branch from 95f0738 to 2c4390b Compare December 30, 2019 22:21

Add billing instructions API.

c4adf6b

wilcobmsft force-pushed the wilcob/billingInstructions branch from 2c4390b to c4adf6b Compare December 30, 2019 22:52

raych1 reviewed Dec 31, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Outdated Show resolved Hide resolved

Update description: 'by id' -> 'by name'.

b223b1e

anthony-c-martin requested changes Jan 2, 2020

View reviewed changes

anthony-c-martin added the ARMChangesRequested label Jan 2, 2020

Fix description: id->name.

5096e68

anthony-c-martin reviewed Jan 2, 2020

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Outdated Show resolved Hide resolved

Rename BillingInstruction->Instruction.

01ef4a8

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 2, 2020

raych1 approved these changes Jan 3, 2020

View reviewed changes

anthony-c-martin approved these changes Jan 3, 2020

View reviewed changes

raych1 merged commit 976254f into Azure:master Jan 6, 2020

Conversation

wilcobmsft commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azuresdkci commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 31, 2019

Uh oh!

Uh oh!

anthony-c-martin Jan 2, 2020

Choose a reason for hiding this comment

Uh oh!

wilcobmsft Jan 2, 2020

Choose a reason for hiding this comment

Uh oh!

anthony-c-martin Jan 2, 2020

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Jan 2, 2020

Uh oh!

Uh oh!

azure-pipelines bot commented Jan 2, 2020

Uh oh!

raych1 commented Jan 3, 2020

Uh oh!

anthony-c-martin commented Jan 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

wilcobmsft commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading