[SRP] Support file share soft delete (restoreShare API) by zfchen95 · Pull Request #7988 · Azure/azure-rest-api-specs

zfchen95 · 2019-12-16T20:09:27Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2019-12-16T20:09:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2019-12-16T20:10:34Z

Can one of the admins verify this patch?

zfchen95 · 2019-12-16T20:11:56Z

@Juliehzl @blueww for review

openapi-sdkautomation · 2019-12-16T20:12:12Z

azure-sdk-for-java

❌ failed [Logs] [Expand Details]

❌ Generate from ace3f34 with merge commit 4234c5808272ca67a64de55af4981c71ea1118cc. SDK Automation 13.0.17.20200326.3

[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
[AutoRest] FATAL: swagger-document/individual/schema-validator - FAILED
[AutoRest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Failure during batch task - {"tag":"package-2019-06"} -- false.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@2.1.95 --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/storage/resource-manager/readme.md ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failure during batch task - {"tag":"package-2019-06"} -- false.
, {}

openapi-sdkautomation · 2019-12-16T20:12:15Z

azure-sdk-for-python

❌ failed [Logs] [Expand Details]

❌ Generate from ace3f34 with merge commit 4234c5808272ca67a64de55af4981c71ea1118cc. SDK Automation 13.0.17.20200326.3

[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
[AutoRest] FATAL: swagger-document/individual/schema-validator - FAILED
[AutoRest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Failure during batch task - {"tag":"package-2019-06"} -- false.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/z/work/azure-sdk-for-python/sdk /z/work/azure-rest-api-specs/specification/storage/resource-manager/readme.md ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failure during batch task - {"tag":"package-2019-06"} -- false.
, {}

openapi-sdkautomation · 2019-12-16T20:12:15Z

azure-sdk-for-go

❌ failed [Logs] [Expand Details]

❌ Generate from ace3f34 with merge commit 4234c5808272ca67a64de55af4981c71ea1118cc. SDK Automation 13.0.17.20200326.3

[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
[AutoRest] FATAL: swagger-document/individual/schema-validator - FAILED
[AutoRest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Failure during batch task - {"tag":"package-2019-06"} -- false.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.142 --go --verbose --multiapi --use-onever --preview-chk --version=2.0.4413 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/storage/resource-manager/readme.md ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failure during batch task - {"tag":"package-2019-06"} -- false.
, {}

openapi-sdkautomation · 2019-12-16T20:12:17Z

azure-sdk-for-net

❌ failed [Logs] [Expand Details]

❌ Generate from ace3f34 with merge commit 4234c5808272ca67a64de55af4981c71ea1118cc. SDK Automation 13.0.17.20200326.3

[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
[AutoRest] FATAL: swagger-document/individual/schema-validator - FAILED
[AutoRest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/z/work/azure-sdk-for-net/sdk /z/work/azure-rest-api-specs/specification/storage/resource-manager/readme.md ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
, {}

openapi-sdkautomation · 2019-12-16T20:12:18Z

azure-sdk-for-js

❌ failed [Logs] [Expand Details]

❌ Generate from ace3f34 with merge commit 4234c5808272ca67a64de55af4981c71ea1118cc. SDK Automation 13.0.17.20200326.3

[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
[AutoRest] ERROR: Schema violation: Expected type array but found type boolean
[AutoRest]     - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
[AutoRest] FATAL: swagger-document/individual/schema-validator - FAILED
[AutoRest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
[AutoRest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.2.2 --typescript-sdks-folder=/z/work/azure-sdk-for-js /z/work/azure-rest-api-specs/specification/storage/resource-manager/readme.md ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:550:10 ($.definitions.DeletedShare.properties.deletedShareVersion.required)
ERROR: Schema violation: Expected type array but found type boolean
    - file:///z/work/azure-rest-api-specs/specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json:545:10 ($.definitions.DeletedShare.properties.deletedShareName.required)
FATAL: swagger-document/individual/schema-validator - FAILED
FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
, {}

azure-pipelines · 2019-12-16T20:56:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-16T20:56:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-16T22:44:53Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2019-12-17T04:45:19Z

/azp run

azure-pipelines · 2019-12-17T04:45:41Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2020-01-21T21:31:47Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-28T03:48:24Z

Azure Pipelines successfully started running 1 pipeline(s).

blueww · 2020-02-13T12:50:04Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json

    },
+    "DeletedShare":{
+      "properties": {
+        "deletedShareName": {


Need to set deletedShareName and deletedShareVersion as required in "DeletedShare", or the current generated SDK from swagger will have the 2 parameters as optional when restore share, but they are actually required on server.

Agree with Wei. Currently the generated SDK doesn't make deletedShareName and deletedShareVersion required, which are not as expected.

azure-pipelines · 2020-03-31T16:59:00Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-31T17:00:21Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

[SRP] Support file share soft delete (restoreShare API)

3030f5a

azuresdkci assigned njuCZ Dec 16, 2019

azuresdkci requested a review from njuCZ December 16, 2019 20:10

Update FileSharesRestore.json

ca463aa

Update file.json

43dc44f

Update file.json

d78dd46

jsntcy requested review from Juliehzl and jsntcy December 17, 2019 01:38

List deleted shares with version, and support rename restored share

5003313

zfchen95 changed the title ~~[SRP][Draft][DoNotMerge] Support file share soft delete (restoreShare API)~~ [SRP][DoNotMerge] Support file share soft delete (restoreShare API) Jan 28, 2020

blueww reviewed Feb 13, 2020

View reviewed changes

zfchen95 mentioned this pull request Feb 20, 2020

CLI support for file share soft delete Azure/azure-cli#12278

Closed

zfchen95 changed the title ~~[SRP][DoNotMerge] Support file share soft delete (restoreShare API)~~ [SRP] Support file share soft delete (restoreShare API) Mar 31, 2020

Make deleted share name and version required

ace3f34

zfchen95 requested a review from JasonYang-MSFT as a code owner March 31, 2020 16:58

zfchen95 requested a review from blueww March 31, 2020 16:59

zfchen95 mentioned this pull request Mar 31, 2020

SRP recent file share API change #8900

Merged

5 tasks

zfchen95 closed this Apr 22, 2020

Comments

Conversation

zfchen95 commented Dec 16, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Dec 16, 2019

Uh oh!

azuresdkci commented Dec 16, 2019

Uh oh!

zfchen95 commented Dec 16, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

azure-pipelines bot commented Dec 16, 2019

Uh oh!

azure-pipelines bot commented Dec 16, 2019

Uh oh!

azure-pipelines bot commented Dec 16, 2019

Uh oh!

PhoenixHe-NV commented Dec 17, 2019

Uh oh!

azure-pipelines bot commented Dec 17, 2019

Uh oh!

azure-pipelines bot commented Jan 21, 2020

Uh oh!

azure-pipelines bot commented Jan 28, 2020

Uh oh!

blueww Feb 13, 2020

Choose a reason for hiding this comment

Uh oh!

Juliehzl Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

zfchen95 Mar 31, 2020

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Mar 31, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-cli-extensions

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Dec 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 16, 2019 •

edited

Loading

openapi-sdkautomation bot commented Mar 31, 2020 •

edited

Loading