[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-10-01 by shbha1 · Pull Request #7972 · Azure/azure-rest-api-specs

shbha1 · 2019-12-13T00:32:00Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…t scopes for Dimensions and Query API

azure-pipelines · 2019-12-13T00:32:18Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-13T00:34:16Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a1552e4 with merge commit 040a211. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-costmanagement [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2019-12-13T00:34:16Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-13T00:34:17Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from a1552e4 with merge commit 040a211. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.CostManagement [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.CostManagement.0.9.0-preview.nupkg
- Microsoft.Azure.Management.CostManagement.0.9.0-preview.snupkg

openapi-sdkautomation · 2019-12-13T00:34:18Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-13T00:34:20Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from a1552e4 with merge commit 040a211. SDK Automation 13.0.17.20191226.1
⚠️costmanagement/mgmt/2018-05-31 [Logs]
```
No file is changed.
```
⚠️costmanagement/mgmt/2019-01-01 [Logs]
```
No file is changed.
```
️✔️costmanagement/mgmt/2019-10-01 [Logs] [Release SDK Changes]
- costmanagement.mgmt.2019-10-01.zip
⚠️preview/costmanagement/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/costmanagement/mgmt/2019-03-01 [Logs]
```
No file is changed.
```

azuresdkci · 2019-12-13T01:01:39Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-16T05:43:17Z

Commenter does not have sufficient privileges for PR 7972 in repo Azure/azure-rest-api-specs

azure-pipelines · 2019-12-17T00:03:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-17T00:49:46Z

Azure Pipelines successfully started running 1 pipeline(s).

yungezz · 2019-12-17T01:24:04Z

hi @shbha1 could you pls fix CI failure, then the PR ok to merge.

yungezz · 2019-12-19T02:06:02Z

ping for update

azure-pipelines · 2019-12-19T18:04:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-19T19:37:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-19T19:52:33Z

Azure Pipelines successfully started running 1 pipeline(s).

shbha1 · 2019-12-19T21:31:06Z

Please confirm if we can merge without fixing the code-style issue the recent check is complaining about.

shbha1 · 2019-12-20T19:43:29Z

What is pending to get this PR merged? (given the check failing is not 'required' i'd like to proceed with the PR)

yungezz · 2019-12-23T01:59:22Z

/azp run

azure-pipelines · 2019-12-23T01:59:44Z

Azure Pipelines successfully started running 3 pipeline(s).

yungezz · 2019-12-23T03:05:46Z

hi @ArcturusZhang could you pls help to look at the GO SDK generation failure? thanks. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=217896&view=logs&j=fae805ed-8bde-5aa7-6387-2396f34533f9&t=c2e6587e-d03c-5fa9-0378-bc3c21e64d38

ArcturusZhang · 2019-12-24T01:59:44Z

hi @ArcturusZhang could you pls help to look at the GO SDK generation failure? thanks. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=217896&view=logs&j=fae805ed-8bde-5aa7-6387-2396f34533f9&t=c2e6587e-d03c-5fa9-0378-bc3c21e64d38

One example file is malformed. I wonder why other CI does not report this.

ArcturusZhang · 2019-12-24T02:03:44Z

And there are also a lot of field that is reported as

model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.

I highly recommend you to add description or title for them. If it is by design, just ignore this.
And autorest also reports some other warnings like this:

OperationId should contain the verb: 'query' in:'Query_Usage'. Consider updating the operationId

Conventionally, operationId should be a puralNoun_Verb form.

yungezz · 2019-12-24T03:22:00Z

hi @ArcturusZhang could you pls help to look at the GO SDK generation failure? thanks. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=217896&view=logs&j=fae805ed-8bde-5aa7-6387-2396f34533f9&t=c2e6587e-d03c-5fa9-0378-bc3c21e64d38

One example file is malformed. I wonder why other CI does not report this.

hi @raych1 could you pls help to have a look why malformed example isn't reported? Thanks.

raych1 · 2019-12-24T06:43:01Z

hi @ArcturusZhang could you pls help to look at the GO SDK generation failure? thanks. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=217896&view=logs&j=fae805ed-8bde-5aa7-6387-2396f34533f9&t=c2e6587e-d03c-5fa9-0378-bc3c21e64d38

One example file is malformed. I wonder why other CI does not report this.

hi @raych1 could you pls help to have a look why malformed example isn't reported? Thanks.

@yungezz , model validation works as expected which has the JSON format error reported on the last 2nd commit CI checks result.

azure-pipelines · 2019-12-26T20:30:25Z

Azure Pipelines successfully started running 1 pipeline(s).

shbha1 · 2019-12-26T21:25:54Z

can we please merge the PR (the failing test says 'prettier check' - not required check failed).

raych1 · 2019-12-27T02:50:01Z

It's interesting that OAV doesn't report when the missing curly bracket is in the end. I logged an issue to track this.

raych1 · 2019-12-27T02:51:43Z

@ArcturusZhang , you requested the changes, can you please review this again?

shbhamsft added 2 commits December 10, 2019 17:33

introduce externalbillingaccount scope for dimension and query api

50697e8

Introduce examples for ExternalSubscription and ExternalBillingAccoun…

e1ae5c6

…t scopes for Dimensions and Query API

azuresdkci assigned yungezz Dec 13, 2019

azuresdkci requested a review from yungezz December 13, 2019 00:32

bug fix - refer to the new example files in json file.

7dfea6b

bug fix - added 200 status in response

a0ad5fc

yungezz approved these changes Dec 17, 2019

View reviewed changes

handled examples issues

987b82f

json fix (duplicate json value)

bb2247a

bug fix - json format was incorrect

a7262c9

ArcturusZhang requested changes Dec 24, 2019

View reviewed changes

Comment thread ...ger/Microsoft.CostManagement/stable/2019-10-01/examples/ExternalSubscriptionsDimensions.json

fix malformed example ExternalSubscriptionsDimensions.json

a1552e4

raych1 mentioned this pull request Dec 27, 2019

Invalid JSON file should report error Azure/oav#470

Closed

raych1 requested a review from ArcturusZhang December 27, 2019 02:50

raych1 approved these changes Dec 27, 2019

View reviewed changes

ArcturusZhang approved these changes Dec 27, 2019

View reviewed changes

raych1 merged commit 040a211 into Azure:master Dec 27, 2019

Conversation

shbha1 commented Dec 13, 2019

Contribution checklist:

Uh oh!

azure-pipelines Bot commented Dec 13, 2019

Uh oh!

openapi-sdkautomation Bot commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation Bot commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation Bot commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation Bot commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

azuresdkci commented Dec 13, 2019

Uh oh!

azure-pipelines Bot commented Dec 16, 2019

Uh oh!

azure-pipelines Bot commented Dec 17, 2019

Uh oh!

azure-pipelines Bot commented Dec 17, 2019

Uh oh!

yungezz commented Dec 17, 2019

Uh oh!

yungezz commented Dec 19, 2019

Uh oh!

azure-pipelines Bot commented Dec 19, 2019

Uh oh!

azure-pipelines Bot commented Dec 19, 2019

Uh oh!

azure-pipelines Bot commented Dec 19, 2019

Uh oh!

shbha1 commented Dec 19, 2019

Uh oh!

shbha1 commented Dec 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungezz commented Dec 23, 2019

Uh oh!

azure-pipelines Bot commented Dec 23, 2019

Uh oh!

yungezz commented Dec 23, 2019

Uh oh!

ArcturusZhang commented Dec 24, 2019

Uh oh!

Uh oh!

ArcturusZhang commented Dec 24, 2019

Uh oh!

yungezz commented Dec 24, 2019

Uh oh!

raych1 commented Dec 24, 2019

Uh oh!

azure-pipelines Bot commented Dec 26, 2019

Uh oh!

shbha1 commented Dec 26, 2019

Uh oh!

raych1 commented Dec 27, 2019

Uh oh!

raych1 commented Dec 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation Bot commented Dec 13, 2019 •

edited

Loading

openapi-sdkautomation Bot commented Dec 13, 2019 •

edited

Loading

openapi-sdkautomation Bot commented Dec 13, 2019 •

edited

Loading

openapi-sdkautomation Bot commented Dec 13, 2019 •

edited

Loading

openapi-sdkautomation Bot commented Dec 13, 2019 •

edited

Loading

shbha1 commented Dec 20, 2019 •

edited

Loading