New APIs for Bastion#7969
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@DarkKnightAnk, could you take a look at all the check errors? |
|
Pull request contains merge conflicts. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@DarkKnightAnk I am good to sign off.. I am trying to understand the piping and TryGetResource(VM).. |
|
Comment was made before the most recent commit for PR 7969 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
left a comment
There was a problem hiding this comment.
Signing off from ARM side with a caveat. Please consider modeling the POST actions as a CRUD-able proxy resource in next iterations of this API.
|
@majastrz Thanks a lot. We will fix this in the next iteration. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@DarkKnightAnk, there are a couple of SDK generation errors for this PR, could you help to check? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
How can we get .Net SDK built with these PR changes? |
* Adding swagger specs for bsl and session management apis for AzureBastion * Update bastionHost.json fixing desc * Added example for session management apis * Update bastionHost.json * Adding parameter location * Fixing build issue * Fixing issues * Fixing style and model issues * fixing style * Update bastionHost.json Adding default to the responses * Update bastionHost.json Fixing typo * Update bastionHost.json Incorporated a few comments * Updating as per comments * Fixing build * Missed updating at one place * Adding in the newer one too * Fixing build issue * Updating name
Latest improvements:
Included new APIs for BastionShareableLink and SessionManagement
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.