Add 202 async support for Account operations by yangyuan · Pull Request #7944 · Azure/azure-rest-api-specs

yangyuan · 2019-12-11T01:30:08Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2019-12-11T01:30:25Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-11T01:30:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-11T01:30:29Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-11T01:30:33Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-11T01:33:07Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10
️✔️cognitiveservices/mgmt/2017-04-18 [Logs] [Release SDK Changes]
- cognitiveservices.mgmt.2017-04-18.zip
⚠️preview/cognitiveservices/mgmt/2016-02-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2019-12-11T01:33:16Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10

⚠️sdk/cognitiveservices/mgmt-v2016_02_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2016_02_01_preview/src/main/java/com/microsoft/azure/management/cognitiveservices/v2016_02_01_preview/implementation/CognitiveServicesAccountImpl.java:[115,41] withTags(java.util.Map) in com.microsoft.azure.management.cognitiveservices.v2016_02_01_preview.implementation.CognitiveServicesAccountImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn]   overridden method is final
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cognitiveservices: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2016_02_01_preview/src/main/java/com/microsoft/azure/management/cognitiveservices/v2016_02_01_preview/implementation/CognitiveServicesAccountImpl.java:[115,41] withTags(java.util.Map) in com.microsoft.azure.management.cognitiveservices.v2016_02_01_preview.implementation.CognitiveServicesAccountImpl cannot override withTags(java.util.Map) in com.microsoft.azure.arm.resources.models.implementation.ResourceImpl
[mvn] [ERROR]   overridden method is final
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/cognitiveservices/mgmt-v2017_04_18 [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysImpl.java:[25,30] cannot find symbol
[mvn]   symbol:   method checkSkuAvailabilitys()
[mvn]   location: class com.microsoft.azure.management.cognitiveservices.v2017_04_18.implementation.CognitiveServicesManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[147,29] incompatible types: java.util.List cannot be converted to java.util.List
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[148,29] incompatible types: com.microsoft.azure.management.cognitiveservices.v2017_04_18.Kind cannot be converted to java.lang.String
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cognitiveservices: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysImpl.java:[25,30] cannot find symbol
[mvn] [ERROR]   symbol:   method checkSkuAvailabilitys()
[mvn] [ERROR]   location: class com.microsoft.azure.management.cognitiveservices.v2017_04_18.implementation.CognitiveServicesManagementClientImpl
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[147,29] incompatible types: java.util.List cannot be converted to java.util.List
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/cognitiveservices/mgmt-v2017_04_18/src/main/java/com/microsoft/azure/management/cognitiveservices/v2017_04_18/implementation/CheckSkuAvailabilitysInner.java:[148,29] incompatible types: com.microsoft.azure.management.cognitiveservices.v2017_04_18.Kind cannot be converted to java.lang.String
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2019-12-11T01:33:57Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10

️✔️@azure/arm-cognitiveservices [Logs] [Release SDK Changes]

azure-arm-cognitiveservices-4.0.0.tgz

[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/cognitiveServicesManagementClient.js → ./dist/arm-cognitiveservices.js...
[npmPack] created ./dist/arm-cognitiveservices.js in 280ms

openapi-sdkautomation · 2019-12-11T01:34:23Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10

️✔️azure-mgmt-cognitiveservices [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2019-12-11T01:34:26Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from b40ba3b with merge commit 6c03f91. SDK Automation 13.0.17.20191212.10

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.CognitiveServices [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.CognitiveServices.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=cognitiveservices /v:n /p:SkipTests=true , {}

erich-wang · 2019-12-11T09:54:42Z

@yangyuan , please fix the error:

 Following response status codes "202" for operation "Accounts_Delete" were
    present in the swagger spec, however they were not present in x-ms-examples.
    Please provide them

azuresdkci · 2019-12-11T16:12:17Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-12T19:39:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-12T21:23:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Add 202 async support for Account operations

7a091b3

azuresdkci assigned erich-wang Dec 11, 2019

azuresdkci requested a review from erich-wang December 11, 2019 01:30

Update samples

d52909e

Fix prettier

b40ba3b

erich-wang approved these changes Dec 13, 2019

View reviewed changes

erich-wang merged commit 6c03f91 into Azure:master Dec 13, 2019

yangyuan mentioned this pull request Jan 7, 2020

Bump Cognitive Services SDK to 7.0 Azure/azure-sdk-for-net#9177

Merged

Conversation

yangyuan commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Dec 11, 2019

Uh oh!

azure-pipelines bot commented Dec 11, 2019

Uh oh!

azure-pipelines bot commented Dec 11, 2019

Uh oh!

azure-pipelines bot commented Dec 11, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

erich-wang commented Dec 11, 2019

Uh oh!

azuresdkci commented Dec 11, 2019

Uh oh!

azure-pipelines bot commented Dec 12, 2019

Uh oh!

azure-pipelines bot commented Dec 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yangyuan commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading