Microsoft.AAD/DomainService: Add 2020-01-01 api-version by jihochang · Pull Request #7901 · Azure/azure-rest-api-specs

jihochang · 2019-12-05T02:00:37Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2019-12-05T02:00:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-05T02:00:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-05T02:01:00Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-05T02:01:02Z

Azure Pipelines successfully started running 1 pipeline(s).

AutorestCI · 2019-12-05T02:01:34Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

openapi-sdkautomation · 2019-12-05T02:03:04Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-05T02:03:04Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-05T02:03:05Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d90be48 with merge commit fde7072. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/163: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 18 Dec 2019 01:55:01 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C2:57C7:2F4EA:6D316:5DF986F4","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4988","x-ratelimit-reset":"1576637697","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.DomainServices@7901","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DomainServices [Logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2019-12-05T02:03:07Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d90be48 with merge commit fde7072. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/57: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 18 Dec 2019 01:55:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C0:41BB:398E0:95AEC:5DF986FF","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4964","x-ratelimit-reset":"1576637697","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-domainservices@7901","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️@azure/arm-domainservices [Logs] [Release SDK Changes]

azure-arm-domainservices-3.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/domainservicesManagementClient.js → ./dist/arm-domainservices.js...
[npmPack] created ./dist/arm-domainservices.js in 249ms

openapi-sdkautomation · 2019-12-05T02:03:10Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d90be48 with merge commit fde7072. SDK Automation 13.0.17.20191213.4
⚠️domainservices/mgmt/2017-01-01 [Logs]
```
No file is changed.
```
⚠️domainservices/mgmt/2017-06-01 [Logs]
```
No file is changed.
```

jihochang · 2019-12-05T19:17:35Z

@fengzhou-msft Could you add the WaitForARMFeedback tag, so that the ARM team can approve this?

Also, I am not sure why the 3 automation tests are failing. Is the ignore test expected to fail? Any ideas?

jihochang · 2019-12-06T01:36:11Z

@fengzhou-msft any update??

azure-pipelines · 2019-12-06T01:36:37Z

Azure Pipelines successfully started running 1 pipeline(s).

fengzhou-msft · 2019-12-06T01:51:48Z

PrettierCheck is optional.

KrisBash

Please see comments

azure-pipelines · 2019-12-09T21:35:41Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-09T22:26:10Z

Azure Pipelines successfully started running 1 pipeline(s).

jihochang · 2019-12-09T22:44:37Z

@KrisBash - I updated the PR with your suggestions. Could you take another look? Thanks!

azuresdkci · 2019-12-11T16:13:37Z

Can one of the admins verify this patch?

jihochang · 2019-12-11T18:28:42Z

@KrisBash - Could you take another look?

jihochang · 2019-12-16T21:41:18Z

@fengzhou-msft Could you merge this PR? ARM has approved the changes.

fengzhou-msft · 2019-12-17T03:33:47Z

@jihochang can you mark the requested changes as addressed? I'm not able to merge the PR with it open.

jihochang · 2019-12-17T20:28:19Z

@fengzhou-msft I think Kristopher Bash needs to approve or be removed from the PR.

Can you try removing him and merging? I pinged him offline and he hasn't gotten back to me.

@KrisBash - could you approve this pull request?

Microsoft.AAD/DomainService: Add 2020-01-01 api-version

51b036c

azuresdkci assigned fengzhou-msft Dec 5, 2019

azuresdkci requested a review from fengzhou-msft December 5, 2019 02:01

fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2019

KrisBash suggested changes Dec 7, 2019

View reviewed changes

KrisBash added the ARMChangesRequested label Dec 7, 2019

Address PR Feedback

d90be48

jihochang requested a review from KrisBash December 11, 2019 18:28

pilor approved these changes Dec 16, 2019

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 16, 2019

fengzhou-msft approved these changes Dec 17, 2019

View reviewed changes

KrisBash approved these changes Dec 17, 2019

View reviewed changes

fengzhou-msft merged commit fde7072 into Azure:master Dec 18, 2019

Conversation

jihochang commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Dec 5, 2019

Uh oh!

azure-pipelines bot commented Dec 5, 2019

Uh oh!

azure-pipelines bot commented Dec 5, 2019

Uh oh!

azure-pipelines bot commented Dec 5, 2019

Uh oh!

AutorestCI commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

jihochang commented Dec 5, 2019

Uh oh!

jihochang commented Dec 6, 2019

Uh oh!

azure-pipelines bot commented Dec 6, 2019

Uh oh!

fengzhou-msft commented Dec 6, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

jihochang commented Dec 9, 2019

Uh oh!

azuresdkci commented Dec 11, 2019

Uh oh!

jihochang commented Dec 11, 2019

Uh oh!

jihochang commented Dec 16, 2019

Uh oh!

fengzhou-msft commented Dec 17, 2019

Uh oh!

jihochang commented Dec 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jihochang commented Dec 5, 2019 •

edited

Loading

AutorestCI commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading