Skip to content

Adding a stable 2019-12-01 API version for licenses.#7880

Merged
njuCZ merged 1 commit intomasterfrom
sornaks/stablelicense
Dec 13, 2019
Merged

Adding a stable 2019-12-01 API version for licenses.#7880
njuCZ merged 1 commit intomasterfrom
sornaks/stablelicense

Conversation

@sornaks
Copy link
Copy Markdown
Contributor

@sornaks sornaks commented Dec 3, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8947

@azuresdkci azuresdkci requested a review from njuCZ December 3, 2019 18:35
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@sornaks sornaks force-pushed the sornaks/stablelicense branch from 9c5528a to d66cb21 Compare December 3, 2019 18:54
KrisBash
KrisBash approved these changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unchanged from prior, and no known issues called out. Signing off for ARM

@KrisBash KrisBash added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 3, 2019
@PhoenixHe-NV
Copy link
Copy Markdown

PhoenixHe-NV commented Dec 4, 2019

/openapi sdkautomation

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 4, 2019

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 4, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Dec 4, 2019 •
edited
Loading

azure-sdk-for-java - Release

⌛ Pending...

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Dec 4, 2019 •
edited
Loading

azure-sdk-for-go - Release

⌛ Pending...

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Dec 4, 2019 •
edited
Loading

azure-sdk-for-net - Release

⌛ Pending...

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Dec 4, 2019 •
edited
Loading

azure-sdk-for-python - Release

⌛ Pending...

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Dec 4, 2019 •
edited
Loading

azure-sdk-for-js - Release

⌛ Pending...

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 4, 2019
Closed
@sornaks sornaks force-pushed the sornaks/stablelicense branch from d66cb21 to cb75597 Compare December 7, 2019 17:26
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 7, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sornaks sornaks force-pushed the sornaks/stablelicense branch from cb75597 to 2473e03 Compare December 7, 2019 17:38
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 7, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@ArcturusZhang
Copy link
Copy Markdown
Member

ArcturusZhang commented Dec 9, 2019

Hi @sornaks if you want go SDK, please add a new entry of the new tag in readme.go.md file.

@sornaks sornaks force-pushed the sornaks/stablelicense branch from 2473e03 to 009a738 Compare December 10, 2019 05:12
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 10, 2019

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 10, 2019
Open
Open
ArcturusZhang
ArcturusZhang requested changes Dec 10, 2019
View reviewed changes
Comment thread specification/softwareplan/resource-manager/readme.go.md Outdated
@sornaks sornaks force-pushed the sornaks/stablelicense branch from 009a738 to 338ab2f Compare December 10, 2019 17:57
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 10, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sornaks sornaks force-pushed the sornaks/stablelicense branch from 338ab2f to 68d7364 Compare December 11, 2019 06:02
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sornaks sornaks force-pushed the sornaks/stablelicense branch from 68d7364 to fa8017b Compare December 11, 2019 06:04
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Dec 11, 2019

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 3 pipeline(s).

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Dec 11, 2019

Can one of the admins verify this patch?

@ArcturusZhang
Copy link
Copy Markdown
Member

ArcturusZhang commented Dec 12, 2019

Hi @qiaozha could you please help on the js generation failure?

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Dec 12, 2019

@sornaks please follow the instructions as I've told you in Teams.

@sornaks sornaks force-pushed the sornaks/stablelicense branch from fa8017b to 470fcf4 Compare December 12, 2019 22:10
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 12, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@njuCZ njuCZ merged commit e80fcbe into master Dec 13, 2019
@JackTn JackTn deleted the sornaks/stablelicense branch August 9, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@njuCZ njuCZ Awaiting requested review from njuCZ

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@njuCZ njuCZ

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sornaks @AutorestCI @PhoenixHe-NV @ArcturusZhang @qiaozha @azuresdkci @KrisBash @njuCZ