DeploymentManager API 2019-11-preview by deveshguha · Pull Request #7871 · Azure/azure-rest-api-specs

deveshguha · 2019-12-02T21:14:47Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-12-02T21:16:06Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8921

AutorestCI · 2019-12-02T21:17:19Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6464

...source-manager/Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json

KrisBash

Please see comments. For reference, I only reviewed the deltas in this version including:

polymorphic step resource with healthCheck
renamed type
new LIST apis at RG scope

...source-manager/Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json

azure-pipelines · 2019-12-04T19:29:34Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-04T19:31:35Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 40fc925 with merge commit 43fde54. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/104: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 13 Dec 2019 07:27:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C1:0F18:A9DB82:1A9B791:5DF33D7C","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4981","x-ratelimit-reset":"1576225672","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_arm-deploymentmanager@7871","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2019-12-04T19:31:37Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 40fc925 with merge commit 43fde54. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-java/pull/252: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 13 Dec 2019 07:28:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C5:3173:173729D:3C7C7CF:5DF33D8B","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4940","x-ratelimit-reset":"1576225672","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-java/git/refs/heads/sdkAutomation/sdk_deploymentmanager_mgmt-v2019-11-01-preview@7871","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

⚠️sdk/deploymentmanager/mgmt-v2019-11-01-preview [Logs] [Release SDK Changes]

[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-deploymentmanager: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.deploymentmanager.v2019-11-01-preview"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/deploymentmanager/mgmt-v2019-11-01-preview/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

openapi-sdkautomation · 2019-12-04T19:31:39Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40fc925 with merge commit 43fde54. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/195: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 13 Dec 2019 07:27:59 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C1:78D3:28C91E7:5E0D733:5DF33D7E","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4969","x-ratelimit-reset":"1576225672","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-net/git/refs/heads/sdkAutomation/Microsoft.Azure.Management.DeploymentManager@7871","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DeploymentManager [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.DeploymentManager.0.9.1-preview.nupkg
- Microsoft.Azure.Management.DeploymentManager.0.9.1-preview.snupkg

openapi-sdkautomation · 2019-12-04T19:31:39Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 40fc925 with merge commit 43fde54. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1101: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 13 Dec 2019 07:28:07 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07DF:0D15:24873CC:570A807:5DF33D86","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4946","x-ratelimit-reset":"1576225672","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/preview_deploymentmanager_mgmt_2019-11-01-preview@7871","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

⚠️preview/deploymentmanager/mgmt/2018-09-01-preview [Logs]
```
No file is changed.
```
️✔️preview/deploymentmanager/mgmt/2019-11-01-preview [Logs] [Release SDK Changes]
- preview.deploymentmanager.mgmt.2019-11-01-preview.zip

openapi-sdkautomation · 2019-12-04T19:31:43Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 40fc925 with merge commit 43fde54. SDK Automation 13.0.17.20191213.4

Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/88: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 13 Dec 2019 07:28:02 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C1:66EC:25F2386:592E521:5DF33D82","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4960","x-ratelimit-reset":"1576225672","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-deploymentmanager@7871","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.13.1 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}

️✔️azure-mgmt-deploymentmanager [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

deveshguha · 2019-12-04T19:58:50Z

azure-sdk-for-net

❌ failed [Logs] [Expand Details]

The type 'Step' was renamed to 'StepGroup' and that is causing the Tests project in the sdk repo to fail. The tests need to be enhanced for this new API version to reference the renamed type.

KrisBash

Signing off with comment

deveshguha · 2019-12-07T01:30:27Z

@yungezz please do not merge this PR yet. We're planning on making a small enhancement to the PR.

yungezz · 2019-12-09T02:26:24Z

@yungezz please do not merge this PR yet. We're planning on making a small enhancement to the PR.

sure. pls add label "DoNotMerge" for PRs not ready for merge. Thanks.

azure-pipelines · 2019-12-09T23:44:14Z

Azure Pipelines successfully started running 1 pipeline(s).

yungezz · 2019-12-11T04:52:51Z

@andyliuliming confirmed the NET SDK failure is not swagger issue, force merge this PR.

deveshguha added 5 commits November 7, 2019 18:42

Add new Api version

55330e4

Adjust suppression rules

ca66b4f

Java SDK auto-gen setting change

4c29532

Java SDK output folder fix

fee6f1c

Merge branch 'master' into deoletim-adm-2019-11

a6b4c08

AutorestCI mentioned this pull request Dec 2, 2019

[AutoPR deploymentmanager/resource-manager] DeploymentManager API 2019-11-preview Azure/azure-sdk-for-python#8921

Closed

azuresdkci assigned yungezz Dec 2, 2019

azuresdkci requested a review from yungezz December 2, 2019 21:16

AutorestCI mentioned this pull request Dec 2, 2019

[AutoPR deploymentmanager/resource-manager] DeploymentManager API 2019-11-preview Azure/azure-sdk-for-go#6464

Closed

deveshguha added 4 commits December 2, 2019 13:29

Fix validation errors

8fc7521

Fix Model validation, Add custom words

c2bd4be

Fix examples

e826924

Fix casing for health check example

ed3034c

yungezz reviewed Dec 3, 2019

View reviewed changes

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2019

Rename Step type that references stepGroups to StepGroup

66cf472

KrisBash suggested changes Dec 4, 2019

View reviewed changes

KrisBash added the ARMChangesRequested label Dec 4, 2019

Incorporated ARM feedback

06afab0

deveshguha requested a review from KrisBash December 4, 2019 19:29

This was referenced Dec 4, 2019

[AutoPR @azure/arm-deploymentmanager] DeploymentManager API 2019-11-preview AzureSDKAutomation/azure-sdk-for-js#52

Closed

[AutoPR azure-mgmt-deploymentmanager] DeploymentManager API 2019-11-preview AzureSDKAutomation/azure-sdk-for-python#58

Closed

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 5, 2019

KrisBash approved these changes Dec 5, 2019

View reviewed changes

deveshguha requested a review from yungezz December 6, 2019 03:49

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 9, 2019

Add new auth type for REST health checks

40fc925

yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 10, 2019

yungezz merged commit 43fde54 into Azure:master Dec 11, 2019

Conversation

deveshguha commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Dec 4, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

deveshguha commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

deveshguha commented Dec 7, 2019

Uh oh!

yungezz commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

yungezz commented Dec 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deveshguha commented Dec 2, 2019 •

edited

Loading

AutorestCI commented Dec 2, 2019 •

edited

Loading

AutorestCI commented Dec 2, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 4, 2019 •

edited

Loading

deveshguha commented Dec 4, 2019 •

edited

Loading