Skip to content

Update IntegrationRuntime: add new optional property for public ip feature#7866

Merged
ChenTanyi merged 1 commit intoAzure:masterfrom
xuyangit:master
Dec 3, 2019
Merged

Update IntegrationRuntime: add new optional property for public ip feature#7866
ChenTanyi merged 1 commit intoAzure:masterfrom
xuyangit:master

Conversation

@xuyangit
Copy link
Contributor

@xuyangit xuyangit commented Dec 2, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@xuyangit
Copy link
Contributor Author

xuyangit commented Dec 2, 2019

This doesn't bring new api and only add an optional property. So I doesn't introduce ms-examples here.

@AutorestCI
Copy link

AutorestCI commented Dec 2, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8442

@AutorestCI
Copy link

AutorestCI commented Dec 2, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6468

@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 2, 2019
@ChenTanyi ChenTanyi requested a review from zhangyd2015 December 2, 2019 04:58
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 2, 2019
@ChenTanyi ChenTanyi merged commit 212d671 into Azure:master Dec 3, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments