Skip to content

Arm common types#7858

Merged
lirenhe merged 4 commits intoAzure:masterfrom
KrisBash:arm-commonTypes
Jan 15, 2020
Merged

Arm common types#7858
lirenhe merged 4 commits intoAzure:masterfrom
KrisBash:arm-commonTypes

Conversation

@KrisBash
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

This PR is adding a new object "locationData" in the common-types definition file. This is an optional property that can be used by multiple RPs by reference.

@AutorestCI
Copy link

AutorestCI commented Nov 27, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Nov 27, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 28, 2019
@fengzhou-msft
Copy link
Member

Please fix CI error.

@KrisBash KrisBash added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 5, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KrisBash KrisBash removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 23, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 23, 2019

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 23, 2019

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 23, 2019

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 23, 2019

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 23, 2019

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2020
@lirenhe
Copy link
Member

lirenhe commented Jan 14, 2020

@KrisBash, I saw there is still an issue reported by Prettier check, could you follow the guide in https://aka.ms/AA6h31t to fix the issue?

@lirenhe lirenhe merged commit 4878cca into Azure:master Jan 15, 2020
zhenglaizhang pushed a commit to test-repo-billy/azure-rest-api-specs that referenced this pull request Dec 29, 2020
* Fix the prettier check error for types.json (Azure#8211)

* Arm common types (Azure#7858)

* Initial commit of locationData

* countryOrRegion

* "name" is mandatory in locationData

* Update types, locationData, systemData,encrypt

* Arm common types (Azure#7858)

* Initial commit of locationData

* countryOrRegion

* "name" is mandatory in locationData

* Update types, locationData, systemData,encrypt

Co-authored-by: Renhe Li <renhe.li@hotmail.com>
Co-authored-by: Tiano2017 <31759375+Tiano2017@users.noreply.github.com>
Co-authored-by: Kristopher Bash <krbash@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants