Skip to content

DO NOT MERGE: Enabled connectionMonitor V2#7821

Closed
irrogozh wants to merge 2 commits intoAzure:network-december-releasefrom
irrogozh:network-december-release
Closed

DO NOT MERGE: Enabled connectionMonitor V2#7821
irrogozh wants to merge 2 commits intoAzure:network-december-releasefrom
irrogozh:network-december-release

Conversation

@irrogozh
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 21, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Nov 21, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpywjcc64x/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpywjcc64x/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4407).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4407/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4407)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .

<--- Last few GCs --->

[58346:0x3818cc0]    54246 ms: Scavenge 1367.2 (1423.7) -> 1366.5 (1424.2) MB, 4.8 / 0.0 ms  (average mu = 0.291, current mu = 0.268) allocation failure
[58346:0x3818cc0]    54252 ms: Scavenge 1367.4 (1424.2) -> 1366.7 (1424.7) MB, 3.1 / 0.0 ms  (average mu = 0.291, current mu = 0.268) allocation failure
[58346:0x3818cc0]    54259 ms: Scavenge 1367.6 (1424.7) -> 1366.9 (1425.2) MB, 2.9 / 0.0 ms  (average mu = 0.291, current mu = 0.268) allocation failure


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xd925edbe1d]
Security context: 0x0c2f6c09e6e9 <JSObject>
    1: visit(aka visit) [0xc63e0ea3229] [/node_modules/@microsoft.azure/datastore/dist/json-pointer.js:~154] [pc=0xd926374db1](this=0x0ae7304826f1 <undefined>,/* anonymous */=0x0bf1d0009f89 <String[20]: #/definitions/Access>,/* anonymous */=0x0a168ab1d229 <JSArray[5]>)
    2: visit(aka visit) [0xc63e0ea3229] [/node_modules/@microsoft.azure/datastore/dist/json-...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xd925edbe1d

@azuresdkci azuresdkci requested a review from zikalino November 21, 2019 13:13
@irrogozh irrogozh changed the title Enabled connectionMonitor V2 DO NOT MERGE: Enabled connectionMonitor V2 Nov 21, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@PhoenixHe-NV
Copy link

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@irrogozh
Copy link
Member Author

irrogozh commented Dec 5, 2019

We need to close this pr. The correct one is here: #7881

@anton-evseev
Copy link
Contributor

Closed in favor of #7881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants