Skip to content

PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's …#7806

Merged
raych1 merged 13 commits intoAzure:masterfrom
shinilm:orcasbyok
Dec 4, 2019
Merged

PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's …#7806
raych1 merged 13 commits intoAzure:masterfrom
shinilm:orcasbyok

Conversation

@shinilm
Copy link
Contributor

@shinilm shinilm commented Nov 19, 2019

…for BYOK feature

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from raych1 November 19, 2019 23:55
@AutorestCI AutorestCI mentioned this pull request Nov 19, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8728

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6398

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 20, 2019

Can one of the admins verify this patch?

raych1
raych1 reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shinilm , next time please add the previous version of swagger as initial commit then update on top of it so that the review will be easier for the diff part.
Please fix the avocado check failures.

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2019
@shinilm
Copy link
Contributor Author

shinilm commented Nov 20, 2019

@shinilm , next time please add the previous version of swagger as initial commit then update on top of it so that the review will be easier for the diff part.
Please fix the avocado check failures.

This is altogether a new api under and new api version and hence this was newly added.

@shinilm shinilm closed this Nov 20, 2019
@shinilm shinilm reopened this Nov 20, 2019
@AutorestCI AutorestCI mentioned this pull request Nov 21, 2019
Closed
ryansbenson
ryansbenson reviewed Nov 21, 2019
View reviewed changes
@shinilm shinilm requested a review from ryansbenson November 22, 2019 00:26
ryansbenson
ryansbenson approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2019
@raych1 raych1 merged commit 96165d9 into Azure:master Dec 4, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@shinilm @AnuTalluri
PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's … (
f60bea3 
Azure#7806)

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature

* PostgreSQL, MySQL, MariaDB Swagger for the data encryption key api's for BYOK feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raych1 raych1 raych1 approved these changes

@ryansbenson ryansbenson ryansbenson approved these changes

Assignees

@raych1 raych1

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinilm @AutorestCI @azuresdkci @raych1 @ryansbenson