Conversation
Swagger specification for HDInsight Kafka REST proxy
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
mmyyrroonn
added
the
APIStewardshipBoard-ReviewRequested
|
Can one of the admins verify this patch? |
| "tags" : [ { | ||
| "name" : "v1consumer", | ||
| "description" : "Consume messages" | ||
| }, { |
There was a problem hiding this comment.
Could you refine the structure to
{
},
{
},
| "get" : { | ||
| "tags" : [ "v1consumer" ], | ||
| "summary" : "Consume messages using a simple consumer", | ||
| "description" : "", |
There was a problem hiding this comment.
Is this intentional? An empty description is strange.
| "type" : "string" | ||
| }, { | ||
| "in" : "body", | ||
| "name" : "body", |
There was a problem hiding this comment.
Just want to confirm, is this name by design?
| "ConsumeRecord" : { | ||
| "type" : "object", | ||
| "properties" : { | ||
| "value" : { |
There was a problem hiding this comment.
Could we add description?
|
@hrasheed-msft Hello. Could you solve the CI error and address the comments? |
|
@myronfanqiu I have reached out to the dev team that wrote the spec to resolve the issues. I'll update the PR shortly. |
resolving reviewer comments
|
@myronfanqiu The team has updated the spec. Is there a way to exempt the terms causing the first spellcheck test to fail? |
|
@hrasheed-msft you can add your words into https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt |
@myronfanqiu I have added them in this PR: #7855 |
Updating with fixes for reviewer comments
|
@myronfanqiu @devigned The json file has been updated based on reviewer comments. |
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
LGTM @devigned Could you confirm whether you have more concerns about this PR or not?
|
👍 |
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
5 participants
Swagger specification for HDInsight Kafka REST proxy
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.