Skip to content

Fix response structure#7790

Merged
erich-wang merged 5 commits intomasterfrom
unknown repository
Dec 2, 2019
Merged

Fix response structure#7790
erich-wang merged 5 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Nov 16, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Nov 16, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8705

@AutorestCI AutorestCI mentioned this pull request Nov 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6457

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 16, 2019

Can one of the admins verify this patch?

@ghost ghost requested review from DavidLiCIG and yangyuan as code owners November 16, 2019 02:52
@AutorestCI AutorestCI mentioned this pull request Nov 16, 2019
Closed
@ghost
Copy link
Author

ghost commented Nov 16, 2019

Hi,
The SDK generated based on version 2019-08-01 is broken as we changed the our response structure. In order to fix this version, the schema must be updated accordingly.

@AutorestCI AutorestCI mentioned this pull request Nov 16, 2019
Closed
erich-wang
erich-wang suggested changes Nov 19, 2019
View reviewed changes
@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2019
@AutorestCI AutorestCI mentioned this pull request Nov 19, 2019
Merged
@ghost
Copy link
Author

ghost commented Nov 22, 2019

@ryansbenson
Can you approve and merge the PR? Thank you very much

@ghost
Copy link
Author

ghost commented Nov 26, 2019

Hi, can anyone merge the PR, if no, could you please advice what's blocker?
Thanks!

sanjaiganesh
sanjaiganesh reviewed Nov 27, 2019
View reviewed changes
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2019-08-01/cosmos-db.json
"properties": {
"path": {
"type": "string",
"description": "The path for which the indexing behavior applies to. Index paths typically start with root and end with wildcard (/path/*)"
Copy link
Contributor

@sanjaiganesh sanjaiganesh Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "pattern": property to define the regex. helps fail early.. probably at SDK layer.

@sanjaiganesh
Copy link
Contributor

sanjaiganesh commented Nov 27, 2019

Add ARM sign off.. Breaking changes.. but it seems service is behaving this way and just fixing Swagger.

@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 27, 2019
@erich-wang erich-wang merged commit afdfd93 into Azure:master Dec 2, 2019
@ghost ghost mentioned this pull request Dec 3, 2019
Merged
5 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@bizarreWizard @AnuTalluri
Fix response structure (Azure#7790)
dac665e 
* Fix response structure

* Add new properties and fix CI

* Remove unrelated properties

* Remove unrelated properties

* revert unrelated change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AutorestCI @azuresdkci @sanjaiganesh @yangyuan @erich-wang @ryansbenson

Comments