Skip to content

[SQL] Add Private Endpoint Connections to Server Properties#7783

Merged
akning-ms merged 8 commits intoAzure:masterfrom
beoberha:sql/pecs-in-get-server-swagger
Feb 4, 2020
Merged

[SQL] Add Private Endpoint Connections to Server Properties#7783
akning-ms merged 8 commits intoAzure:masterfrom
beoberha:sql/pecs-in-get-server-swagger

Conversation

@beoberha
Copy link
Contributor

@beoberha beoberha commented Nov 14, 2019 •
edited by akning-ms
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@beoberha beoberha requested a review from jaredmoo as a code owner November 14, 2019 21:16
@AutorestCI AutorestCI mentioned this pull request Nov 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8590

@AutorestCI
Copy link

AutorestCI commented Nov 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 14, 2019

Can one of the admins verify this patch?

@weidongxu-microsoft weidongxu-microsoft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Nov 15, 2019
ryansbenson
ryansbenson reviewed Nov 18, 2019
View reviewed changes
KrisBash
KrisBash suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

@sanjaiganesh
Copy link
Contributor

sanjaiganesh commented Jan 7, 2020

@beoberha please address the comments.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 22, 2020

Pull request contains merge conflicts.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 22, 2020

No commit pushedDate could be found for PR 7783 in repo Azure/azure-rest-api-specs

@beoberha beoberha requested review from anthony-c-martin and removed request for v-shhatt January 31, 2020 22:23
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 31, 2020
@beoberha beoberha changed the title [Do not Merge] [SQL] Add Private Endpoint Connections to Server Properties [SQL] Add Private Endpoint Connections to Server Properties Jan 31, 2020
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 31, 2020

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 31, 2020
Closed
Closed
Closed
Closed
Closed
@weidongxu-microsoft weidongxu-microsoft removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 1, 2020
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Feb 1, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 1, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 2, 2020
Closed
Closed
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms akning-ms merged commit 21a0568 into Azure:master Feb 4, 2020
ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
@beoberha @ssripadham
[SQL] Add Private Endpoint Connections to Server Properties (Azure#7783)
4d9f990 
* initial commit 2015-05-01-preview for diff purposes

* actual change

* Address comments

* remove elnata's fix

* Fix SDK

* fix resource identity

* Prettied
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@beoberha @00Kai0
[SQL] Add Private Endpoint Connections to Server Properties (Azure#7783)
7a203e9 
* initial commit 2015-05-01-preview for diff purposes

* actual change

* Address comments

* remove elnata's fix

* Fix SDK

* fix resource identity

* Prettied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@arv100kri arv100kri Awaiting requested review from arv100kri

@bleroy bleroy Awaiting requested review from bleroy

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

@hyonholee hyonholee Awaiting requested review from hyonholee

@kalyanaj kalyanaj Awaiting requested review from kalyanaj

@matthchr matthchr Awaiting requested review from matthchr

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@anton-evseev anton-evseev Awaiting requested review from anton-evseev

@samkreter samkreter Awaiting requested review from samkreter

@schaabs schaabs Awaiting requested review from schaabs

@solankisamir solankisamir Awaiting requested review from solankisamir

@stankovski stankovski Awaiting requested review from stankovski

@xingwu1 xingwu1 Awaiting requested review from xingwu1

@yangyuan yangyuan Awaiting requested review from yangyuan

+2 more reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@KrisBash KrisBash KrisBash requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weidongxu-microsoft weidongxu-microsoft

@akning-ms akning-ms

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@beoberha @AutorestCI @azuresdkci @sanjaiganesh @weidongxu-microsoft @jaredmoo @KrisBash @anthony-c-martin @ryansbenson @akning-ms

Comments