[Hub Generated] Review request for Microsoft.Cache to add version preview/2019-07-01-preview#7761
Merged
zikalino merged 6 commits intoAzure:masterfrom Nov 22, 2019
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Contributor
|
Can one of the admins verify this patch? |
TimLovellSmith
approved these changes
Nov 12, 2019
Member
TimLovellSmith
left a comment
TimLovellSmith
left a comment
There was a problem hiding this comment.
Looking good so far, just a couple clarifications that i think its useful to add.
specification/redis/resource-manager/Microsoft.Cache/preview/2019-07-01-preview/redis.json
Outdated
Show resolved
Hide resolved
specification/redis/resource-manager/Microsoft.Cache/preview/2019-07-01-preview/redis.json
Outdated
Show resolved
Hide resolved
zikalino
added
the
WaitForARMFeedback
Member
|
LGTM. Thanks for making these changes! |
TimLovellSmith
approved these changes
Nov 14, 2019
ryansbenson
added
ARMSignedOff
ryansbenson
approved these changes
Nov 18, 2019
Contributor
ryansbenson
left a comment
ryansbenson
left a comment
There was a problem hiding this comment.
Approved from ARMs side
zikalino
approved these changes
Nov 22, 2019
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2019
…view/2019-07-01-preview (Azure#7761) * Adds base for updating Microsoft.Cache from version stable/2018-03-01 to version 2019-07-01-preview * Updates readme * Updates API version in new specs and examples * Adding RedisInstanceDetails and ReplicasPerMaster property * Prettier fixes * Addressing PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: