Skip to content

Change "required" property from "false" to "true" for parameters in request body#7758

Merged
lirenhe merged 6 commits intomasterfrom
app-platform-2019-05-01-required-property
Nov 28, 2019
Merged

Change "required" property from "false" to "true" for parameters in request body#7758
lirenhe merged 6 commits intomasterfrom
app-platform-2019-05-01-required-property

Conversation

@bowen5
Copy link
Contributor

@bowen5 bowen5 commented Nov 11, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 11, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8900

@AutorestCI
Copy link

AutorestCI commented Nov 11, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6353

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lirenhe
Copy link
Member

lirenhe commented Nov 13, 2019

@bowen5, please fix the errors detected in ModelValidation.

@bowen5
Copy link
Contributor Author

bowen5 commented Nov 14, 2019

@bowen5, please fix the errors detected in ModelValidation.

Fixed. Please help to review again. Thanks.

@lirenhe
Copy link
Member

lirenhe commented Nov 15, 2019

@bowen5, please run prettier to fix code style issues.

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 19, 2019
@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 27, 2019
@lirenhe lirenhe merged commit 98c7412 into master Nov 28, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
…equest body (Azure#7758)

* Change "required" property from "false" to "true" for parameters in request body.

* Update body parameter name in examples.

* Remove readonly properties from swagger example.

* Remove readonly properties from swagger example.e

* Fix Prettier error.
@PhoenixHe-NV
Copy link

/azp run automation - sdk

@JackTn JackTn deleted the app-platform-2019-05-01-required-property branch August 9, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants