Skip to content

Added configuration to generate c# sdk for CosmosDB service.#7737

Merged
yungezz merged 4 commits intoAzure:masterfrom
MehaKaushik:users/mekaushi/csharpsdk
Nov 26, 2019
Merged

Added configuration to generate c# sdk for CosmosDB service.#7737
yungezz merged 4 commits intoAzure:masterfrom
MehaKaushik:users/mekaushi/csharpsdk

Conversation

@MehaKaushik
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8705

@MehaKaushik
Copy link
Contributor Author

@yungezz Can you please have a look at this PR. It is not a very big change. Shouldn't take a lot of time.

- repo: azure-sdk-for-go
- repo: azure-sdk-for-js
- repo: azure-sdk-for-node
- repo: azure-sdk-for-ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls not update this part, this is configuration for our internal CI tool, not for SDK generation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it.

@yungezz
Copy link
Member

yungezz commented Nov 16, 2019

@isra-fel could you pls look at this PR also since it's C# config? thanks.

@isra-fel
Copy link
Member

C# part looks good to me.

@yungezz
Copy link
Member

yungezz commented Nov 16, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yungezz
Copy link
Member

yungezz commented Nov 16, 2019

@MehaKaushik once you removed internal config change, and CI passed, the PR is ok to merge.

@yungezz
Copy link
Member

yungezz commented Nov 21, 2019

hi @MehaKaushik once change on internal config mentioned in prevoius comments revert, the pr is ok to merge

@AutorestCI
Copy link

AutorestCI commented Nov 25, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@MehaKaushik
Copy link
Contributor Author

@yungezz made the required change. Apologies for delay, OOF previously.

@yungezz yungezz merged commit 0cc19d9 into Azure:master Nov 26, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments