Skip to content

Comments

Update swagger spec to add existing log analytics workspace#7728

Merged
yaohaizh merged 6 commits intoAzure:masterfrom
persiaAziz-zz:syaziz/updatelawsswagger
Nov 18, 2019
Merged

Update swagger spec to add existing log analytics workspace#7728
yaohaizh merged 6 commits intoAzure:masterfrom
persiaAziz-zz:syaziz/updatelawsswagger

Conversation

@persiaAziz-zz
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8604

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6373

Copy link

@tniek tniek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2019
@persiaAziz-zz
Copy link
Author

Any update on this PR? @yaohaizh

@yaohaizh
Copy link
Contributor

@persiaAziz need review from ARM review board.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2019
@ravbhatnagar
Copy link
Contributor

preview API-version. adding new writable properties. But signing off as it should be ok in preview api.

@persiaAziz-zz persiaAziz-zz force-pushed the syaziz/updatelawsswagger branch from c6be272 to e9c43e1 Compare November 14, 2019 23:01
@persiaAziz-zz
Copy link
Author

@yaohaizh can you please review. I fixed the merge conflicts by rebasing

@yaohaizh yaohaizh merged commit b1c1a2b into Azure:master Nov 18, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
* Update swagger spec to add existing log analytics workspace

* remove read only

* changes

* pretty

* ID changed to Id

* run prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants