Skip to content

Comments

[Routing Preference] Adding routing preferences API changes, private repo PR# 973#7689

Merged
sergey-shandar merged 2 commits intoAzure:masterfrom
HimanshuChhabra:routing_pref
Nov 4, 2019
Merged

[Routing Preference] Adding routing preferences API changes, private repo PR# 973#7689
sergey-shandar merged 2 commits intoAzure:masterfrom
HimanshuChhabra:routing_pref

Conversation

@HimanshuChhabra
Copy link
Member

@HimanshuChhabra HimanshuChhabra commented Nov 1, 2019

…repo PR#973

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8379

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6252

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 4, 2019
@HimanshuChhabra HimanshuChhabra changed the title [Routing Preference] Adding routing preferences API changes, private … [Routing Preference] Adding routing preferences API changes, private repo PR# 973 Nov 4, 2019
@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 4, 2019
@sergey-shandar
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants