Changes on Key Vault Management Swagger for Private Endpoints

[msfcolombo]

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[openapi-sdkautomation]

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

• ️✔️ Generate from f8168dd with merge commit 2253a5d. SDK Automation 13.0.17.20191226.1

  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied
  [AutoRest] realpath(): Permission denied

• ️✔️Microsoft.Azure.Management.KeyVault [Logs]  [Release SDK Changes]
  • Microsoft.Azure.Management.KeyVault.2.4.3.nupkg
  • Microsoft.Azure.Management.KeyVault.2.4.3.snupkg

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6158

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpq8nvzu58/rest/specification/keyvault/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpvd16re_j']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

[msfcolombo]

@tjprescott @schaabs, please let me know if some action from my side is required. Thanks

[tjprescott]

@Azure/arm-api-review-board please take a look

[majastrz]

I added some comments. Please take a look.

[KrisBash]

Left a couple comments. I think we just need the LIST api and "default" responses to sign off. Please confirm that the PUT is synchronous.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[msfcolombo]

@schaabs @KrisBash @majastrz

I've answered all your inquiries with comments or modifications. Please take another look.

Thanks

[tjprescott]

@Azure/arm-api-review-board please take a look.

[sanjaiganesh]

"x-ms-long-running-operation": true [](start = 7, length = 36)

also add following to help SDK know which one to use for tracking LRO

add "x-ms-long-running-operation-options" extension with "final-state-via" property.

"x-ms-long-running-operation-options": {
  "final-state-via": "location"
}

or

"x-ms-long-running-operation-options": {
  "final-state-via": "azure-async-operation"
}

[sanjaiganesh]

same with other LROs (returning 202 or 201)

---

In reply to: 368137466 [](ancestors = 368137466)

[tjprescott]

@sanjaiganesh since you have signed off for ARM, can you dismiss reviews for @KrisBash and @majastrz (assuming their comments are addressed). I cannot dismiss their review, nor can I merge the PR with any "changes requested".

[ShaneBala-keyvault]

@sanjaiganesh ping on this, since ARM has signed off, can we dismiss the remaining issues and merge this PR?

[tjprescott]

Yes, I can re-approve the PR, but until those reviews are accepted or dismissed (I can't do either) I can't merge this.

[yungezz]

hi @NullMDR , could you pls help to look at why the Ignore task blocking PR merging? thanks.

[PhoenixHe-NV]

It's OK. Good to merge.