Skip to content

[SRP] Add delete retention policy for blob container and file share #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yungezz merged 1 commit into from
Oct 31, 2019
Merged

[SRP] Add delete retention policy for blob container and file share #7626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,8 @@
"description": "DefaultServiceVersion indicates the default version to use for requests to the Blob service if an incoming request’s version is not specified. Possible values include version 2008-10-27 and all more recent versions."
},
"deleteRetentionPolicy": {
"$ref": "#/definitions/DeleteRetentionPolicy",
"description": "The blob service properties for soft delete."
"$ref": "./common.json#/definitions/DeleteRetentionPolicy",
"description": "The blob service properties for blob soft delete."
},
"automaticSnapshotPolicyEnabled": {
"type": "boolean",
Expand All @@ -1142,6 +1142,10 @@
"changeFeed": {
"$ref": "#/definitions/ChangeFeed",
"description": "The blob service properties for change feed events."
},
"containerDeleteRetentionPolicy": {
Copy link
Member

@yungezz yungezz Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the neww property will be think as breaking change in stable version. suggest to add it in new version

Copy link
Member

@blueww blueww Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yungezz
I don't see any reason why add new properties are breaking change, would you please give some reason.
And we have add new properties in same API verison before, but not take as breaking.
Per my understanding, REmove/modify a property will breaking, but add new properties are not breaking.

Copy link
Member

@yungezz yungezz Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/adx-documentation-pr/wiki/Breaking-changes-guidelines#new-required-property-added-to-request,
https://github.com/Azure/adx-documentation-pr/wiki/Breaking-changes-guidelines#new-property-added-to-response

Copy link
Contributor Author

@zfchen95 zfchen95 Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yunge, I understand your concern. Adding a new property can cause data lost during update. June19 is the version we added last week. We can't afford to add a new version for every new feature. As Wei mentioned, we have been adding properties in the same API version before, which does not cause any issue.

Copy link
Member

@blueww blueww Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yungezz
Thanks for the sharing, from the doc I see : "This will overwrite the change made by the first customer from the portal."

Per my understanding, in current storage object update request, if the request send to server does not contain a property (since not get from server), the property will keep the origin value and won't be updated. @zfchen95 , would you please confirm?
In this case, the GET-PUT pipeline won't be broken, so there are no breaking change.

Copy link
Contributor Author

@zfchen95 zfchen95 Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. If the property is not shown in the request, it will not clear the property.

Copy link
Member

@blueww blueww Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yungezz
Do you agree adding the new property in this PR is not a breaking? since it won't break the GET-PUT pipeline. Let us know if you still have concern on this.

Copy link
Member

@yungezz yungezz Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww as long as service team can make sure no user breaking experience, we're ok to it.

"$ref": "./common.json#/definitions/DeleteRetentionPolicy",
"description": "The blob service properties for container soft delete."
}
},
"x-ms-client-flatten": true,
Expand Down Expand Up @@ -1177,21 +1181,6 @@
},
"description": "The blob service properties for change feed events."
},
"DeleteRetentionPolicy": {
"properties": {
"enabled": {
"type": "boolean",
"description": "Indicates whether DeleteRetentionPolicy is enabled for the Blob service."
},
"days": {
"type": "integer",
"minimum": 1,
"maximum": 365,
"description": "Indicates the number of days that the deleted blob should be retained. The minimum specified value can be 1 and the maximum value can be 365."
}
},
"description": "The blob service properties for soft delete."
},
"LeaseContainerRequest": {
"properties": {
"action": {
Expand Down
15 changes: 15 additions & 0 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,21 @@
"allowedHeaders"
],
"description": "Specifies a CORS rule for the Blob service."
},
"DeleteRetentionPolicy": {
"properties": {
"enabled": {
"type": "boolean",
"description": "Indicates whether DeleteRetentionPolicy is enabled for the Blob service."
},
"days": {
"type": "integer",
"minimum": 1,
"maximum": 365,
"description": "Indicates the number of days that the deleted blob should be retained. The minimum specified value can be 1 and the maximum value can be 365."
}
},
"description": "The blob service properties for soft delete."
}
}
}
4 changes: 4 additions & 0 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,10 @@
"cors": {
"$ref": "./common.json#/definitions/CorsRules",
"description": "Specifies CORS rules for the File service. You can include up to five CorsRule elements in the request. If no CorsRule elements are included in the request body, all CORS rules will be deleted, and CORS will be disabled for the File service."
},
"shareDeleteRetentionPolicy": {
Copy link
Member

@yungezz yungezz Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

Copy link
Member

@blueww blueww Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

"$ref": "./common.json#/definitions/DeleteRetentionPolicy",
"description": "The file service properties for share soft delete."
}
},
"x-ms-client-flatten": true,
Expand Down