Skip to content

Swagger update for Azure Private Link Integration for Azure Database for PostgreSQL, MySQL and MariaDB#7585

Merged
tjprescott merged 1 commit intoAzure:masterfrom
ramnov:privateip
Oct 23, 2019
Merged

Swagger update for Azure Private Link Integration for Azure Database for PostgreSQL, MySQL and MariaDB#7585
tjprescott merged 1 commit intoAzure:masterfrom
ramnov:privateip

Conversation

@ramnov
Copy link
Copy Markdown
Contributor

@ramnov ramnov commented Oct 22, 2019 •
edited
Loading

Swagger update for Azure Private Link Integration for Azure Database for PostgreSQL, MySQL and MariaDB

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Oct 22, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from c73fb52, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress mariadb/mgmt/2018-06-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • In-Progress @azure/arm-postgresql [Logs]

@azuresdkci azuresdkci requested a review from tjprescott October 22, 2019 23:27
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Oct 22, 2019

Can one of the admins verify this patch?

@openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Oct 22, 2019
Merged
@ramnov ramnov changed the title Swagger update for Azure Private Link Integration for Azure Database … Swagger update for Azure Private Link Integration for Azure Database for PostgreSQL, MySQL and MariaDB Oct 22, 2019
@ramnov
Copy link
Copy Markdown
Contributor Author

ramnov commented Oct 22, 2019

https://github.com/Azure/azure-rest-api-specs-pr/pull/940

tjprescott
tjprescott approved these changes Oct 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on private PR approval.

@tjprescott tjprescott merged commit cb3f3dd into Azure:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

Assignees

@tjprescott tjprescott

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramnov @AutorestCI @azuresdkci @tjprescott