Skip to content

Microsoft Azure StorageCache - Add 204 response code to cache flush, start, stop and upgrade operation.#7584

Merged
yungezz merged 2 commits intoAzure:masterfrom
romahamu:5605028_fix_nocontent_statuscode
Oct 27, 2019
Merged

Microsoft Azure StorageCache - Add 204 response code to cache flush, start, stop and upgrade operation.#7584
yungezz merged 2 commits intoAzure:masterfrom
romahamu:5605028_fix_nocontent_statuscode

Conversation

@romahamu
Copy link
Contributor

@romahamu romahamu commented Oct 22, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 22, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 3a72ff1, Iteration 2)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning storagecache/resource-manager/v2019_08_01 [Logs]
  • In-Progress storagecache/resource-manager/v2019_11_01 [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-storagecache [Logs]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci azuresdkci requested a review from anuchandy October 22, 2019 22:04
@AutorestCI AutorestCI mentioned this pull request Oct 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6164

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 22, 2019
Merged
@anthony-c-martin anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 22, 2019
@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 22, 2019

Can one of the admins verify this patch?

@yungezz yungezz merged commit 08800e5 into Azure:master Oct 27, 2019
@AutorestCI AutorestCI mentioned this pull request Oct 27, 2019
Merged
@romahamu romahamu mentioned this pull request Nov 3, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yungezz yungezz yungezz approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

Assignees

@anuchandy anuchandy

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@romahamu @AutorestCI @azuresdkci @yungezz @anuchandy @anthony-c-martin