Changed WebActivity and webhook activity auth to support both AKV and…#7554
Merged
erich-wang merged 1 commit intoAzure:masterfrom Oct 24, 2019
Merged
Changed WebActivity and webhook activity auth to support both AKV and…#7554erich-wang merged 1 commit intoAzure:masterfrom
erich-wang merged 1 commit intoAzure:masterfrom
Conversation
In Testing, Please Ignore[Logs] (Generated from 60f4598, Iteration 1)
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
@erich-wang can you please review this PR. The changes in this are not breaking as the type change is to base class. Let me know if you need any other details. |
erich-wang
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Secrets
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.