Skip to content

Fix PATCH operations in Network #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 7 commits into from
Oct 21, 2019
Merged

Fix PATCH operations in Network #7542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20291ad
Removed lro tag from PATCH operations that are synchronous
anton-evseev Oct 16, 2019
467896e
Fix routeFilter's patch
anton-evseev Oct 17, 2019
881c619
More PATCH updates
anton-evseev Oct 17, 2019
abdbdfc
Remove unsupported PATCHes
anton-evseev Oct 17, 2019
74f1963
FirewallPolicy doesn't support PATCH
anton-evseev Oct 18, 2019
06bf88a
Merge branch 'network-october-release' into network-patch
anton-evseev Oct 21, 2019
cd3aa73
Merge branch 'network-october-release' into network-patch
anton-evseev Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...tion/network/resource-manager/Microsoft.Network/stable/2019-09-01/applicationGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,7 @@
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-long-running-operation": true
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways": {
Expand Down
1 change: 0 additions & 1 deletion ...etwork/resource-manager/Microsoft.Network/stable/2019-09-01/applicationSecurityGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@
}
}
},
"x-ms-long-running-operation": true,
"x-ms-examples": {
"Update application security group tags": {
"$ref": "./examples/ApplicationSecurityGroupUpdateTags.json"
Expand Down
6 changes: 3 additions & 3 deletions ...ification/network/resource-manager/Microsoft.Network/stable/2019-09-01/azureFirewall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
"AzureFirewalls"
],
"operationId": "AzureFirewalls_UpdateTags",
"description": "Updates tags for an Azure Firewall resource.",
"description": "Updates tags of an Azure Firewall resource.",
"parameters": [
{
"name": "resourceGroupName",
Expand All @@ -246,9 +246,9 @@
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/AzureFirewall"
"$ref": "./network.json#/definitions/TagsObject"
},
"description": "Parameters supplied to the create or update Azure Firewall operation."
"description": "Parameters supplied to update azure firewall tags."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
Expand Down
3 changes: 1 addition & 2 deletions ...cation/network/resource-manager/Microsoft.Network/stable/2019-09-01/ddosCustomPolicy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
"schema": {
"$ref": "./network.json#/definitions/TagsObject"
},
"description": "Parameters supplied to the update DDoS custom policy resource tags."
"description": "Parameters supplied to update DDoS custom policy resource tags."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
Expand All @@ -256,7 +256,6 @@
}
}
},
"x-ms-long-running-operation": true,
"x-ms-examples": {
"DDoS Custom policy Update tags": {
"$ref": "./examples/DdosCustomPolicyUpdateTags.json"
Expand Down
1 change: 0 additions & 1 deletion ...tion/network/resource-manager/Microsoft.Network/stable/2019-09-01/ddosProtectionPlan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@
}
}
},
"x-ms-long-running-operation": true,
"x-ms-examples": {
"DDoS protection plan Update tags": {
"$ref": "./examples/DdosProtectionPlanUpdateTags.json"
Expand Down
33 changes: 0 additions & 33 deletions ...source-manager/Microsoft.Network/stable/2019-09-01/examples/FirewallPolicyUpdateTags.json
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions ...esource-manager/Microsoft.Network/stable/2019-09-01/examples/P2SVpnGatewayUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,53 +56,6 @@
}
}
}
},
"201": {
"body": {
"name": "p2sVpnGateway1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/P2SvpnGateways/p2sVpnGateway1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"location": "West US",
"type": "Microsoft.Network/p2sVpnGateways",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"virtualHub": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/virtualHub1"
},
"vpnServerConfiguration": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnServerConfigurations/vpnServerConfiguration1"
},
"p2SConnectionConfigurations": [
{
"name": "P2SConnectionConfig1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/p2sVpnGateways/p2sVpnGateway1/p2sConnectionConfigurations/P2SConnectionConfig1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"properties": {
"provisioningState": "Succeeded",
"vpnClientAddressPool": {
"addressPrefixes": [
"101.3.0.0/16"
]
}
}
}
],
"vpnGatewayScaleUnit": 1,
"vpnClientConnectionHealth": {
"vpnClientConnectionsCount": 2,
"allocatedIpAddresses": [
"1.1.1.1",
"2.2.2.2"
],
"totalIngressBytesTransferred": 2000,
"totalEgressBytesTransferred": 3000
}
}
}
}
}
}
37 changes: 0 additions & 37 deletions .../resource-manager/Microsoft.Network/stable/2019-09-01/examples/RouteFilterRuleUpdate.json
View file
Open in desktop

This file was deleted.

16 changes: 1 addition & 15 deletions ...019-09-01/examples/RouteFilterUpdate.json → ...09-01/examples/RouteFilterUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,9 @@
"resourceGroupName": "rg1",
"api-version": "2019-09-01",
"subscriptionId": "subid",
"routeFilterParameters": {
"parameters": {
"tags": {
"key1": "value1"
},
"properties": {
"rules": [
{
"name": "ruleName",
"properties": {
"access": "Allow",
"routeFilterRuleType": "Community",
"communities": [
"12076:5030"
]
}
}
]
}
}
},
Expand Down
23 changes: 0 additions & 23 deletions ...k/resource-manager/Microsoft.Network/stable/2019-09-01/examples/VirtualHubUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,29 +34,6 @@
"sku": "Basic"
}
}
},
"201": {
"body": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/virtualHub2",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"location": "West US",
"name": "virtualHub2",
"type": "Microsoft.Network/virtualHubs",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"virtualWan": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualWans/virtualWan1"
},
"virtualNetworkConnections": [],
"virtualHubRouteTableV2s": [],
"addressPrefix": "10.168.0.0/24",
"sku": "Basic"
}
}
}
}
}
29 changes: 0 additions & 29 deletions ...urce-manager/Microsoft.Network/stable/2019-09-01/examples/VirtualRouterPeeringUpdate.json
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions ...esource-manager/Microsoft.Network/stable/2019-09-01/examples/VirtualRouterUpdateTags.json
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions ...k/resource-manager/Microsoft.Network/stable/2019-09-01/examples/VirtualWANUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,32 +37,6 @@
"type": "Basic"
}
}
},
"201": {
"body": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualWANs/wan1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"location": "West US",
"name": "wan1",
"type": "Microsoft.Network/virtualWANs",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"disableVpnEncryption": false,
"virtualHubs": [
"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/hub1",
"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/hub2"
],
"vpnSites": [
"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnSites/vpnSite1",
"/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnSites/vpnSite2"
],
"type": "Basic"
}
}
}
}
}
44 changes: 0 additions & 44 deletions ...k/resource-manager/Microsoft.Network/stable/2019-09-01/examples/VpnGatewayUpdateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,50 +55,6 @@
}
}
}
},
"201": {
"body": {
"name": "gateway1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnGateways/gateway1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"location": "West US",
"type": "Microsoft.Network/vpnGateways",
"tags": {
"key1": "value1",
"key2": "value2"
},
"properties": {
"provisioningState": "Succeeded",
"virtualHub": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualHubs/virtualHub1"
},
"connections": [
{
"name": "vpnConnection1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnGateways/gateway1/vpnConnections/vpnConnection1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"properties": {
"provisioningState": "Succeeded",
"remoteVpnSite": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/vpnSites/vpnSite1"
},
"connectionStatus": "Connected",
"ingressBytesTransferred": 0,
"egressBytesTransferred": 0,
"routingWeight": 0,
"sharedKey": "key",
"enableBgp": false,
"ipsecPolicies": []
}
}
],
"bgpSettings": {
"asn": 65515,
"bgpPeeringAddress": "10.0.1.30",
"peerWeight": 0
}
}
}
}
}
}
Loading