Skip to content

Fix Virtual Wan Point to site feature resources property names from swagger. #7529

Merged
lirenhe merged 2 commits intoAzure:network-october-releasefrom
Nilambari:network-october-release2019
Oct 20, 2019
Merged

Fix Virtual Wan Point to site feature resources property names from swagger. #7529
lirenhe merged 2 commits intoAzure:network-october-releasefrom
Nilambari:network-october-release2019

Conversation

@Nilambari
Copy link
Member

@Nilambari Nilambari commented Oct 16, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@Nilambari
Copy link
Member Author

This is to get bug fix from August branch:- #7498

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmplavighb6/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmplavighb6/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4405)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .

<--- Last few GCs --->

[10793:0x433dcc0]   109090 ms: Mark-sweep 1377.6 (1424.9) -> 1377.3 (1425.4) MB, 1474.1 / 0.0 ms  (average mu = 0.116, current mu = 0.001) allocation failure scavenge might not succeed
[10793:0x433dcc0]   110924 ms: Mark-sweep 1377.9 (1425.4) -> 1377.7 (1425.9) MB, 1831.9 / 0.0 ms  (average mu = 0.056, current mu = 0.001) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x3f2df3a5be1d]
Security context: 0x25f64bb1e6e9 <JSObject>
    1: /* anonymous */(aka /* anonymous */) [0x13f5ad164ee1] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~120] [pc=0x3f2df40a25f3](this=0x1aa435b826f1 <undefined>,cache=0x254ed107f039 <JSWeakMap>,set=0x13f5ad164fe9 <JSFunction o (sfi = 0x2381a9e8fa69)>)
    2: /* anonymous */(aka /...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3f2df3a5be1d

"gatewayName": "p2sVpnGateway1",
"resourceGroupName": "rg1",
"api-version": "2019-09-01",
"api-version": "2019-08-01",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong API version (in this and other examples)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6064

@lirenhe
Copy link
Member

lirenhe commented Oct 17, 2019

@Nilambari please fix the code check errors in NetworkValidation and modelValidation.

@Nilambari
Copy link
Member Author

@Nilambari please fix the code check errors in NetworkValidation and modelValidation.

Done.

@Nilambari
Copy link
Member Author

Can you Please help approve PR?

@anton-evseev
Copy link
Contributor

@lirenhe please take a look

@lirenhe lirenhe merged commit e8ab263 into Azure:network-october-release Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants