Skip to content

Microsoft Azure StorageCache new API version#7520

Merged
ChenTanyi merged 7 commits intoAzure:masterfrom
romahamu:5117100_new_api_version
Oct 21, 2019
Merged

Microsoft Azure StorageCache new API version#7520
ChenTanyi merged 7 commits intoAzure:masterfrom
romahamu:5117100_new_api_version

Conversation

@romahamu
Copy link
Contributor

@romahamu romahamu commented Oct 16, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 16, 2019

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6092

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8069

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 17, 2019
Copy link
Contributor

@ChenTanyi ChenTanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR title should be changed, since people don't know what resource was added new api from this title.

@romahamu romahamu changed the title 5117100 new api version Microsoft Azure StorageCache new API version Oct 18, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants