[Azure Search] Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06#7511
Conversation
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
arv100kri
left a comment
There was a problem hiding this comment.
You'll have to update the references in the following as well
a497484 to
1e842c3
Compare
arv100kri
left a comment
There was a problem hiding this comment.
Just some minor comments - once addressed I am ready to sign off :)
specification/search/data-plane/Microsoft.Azure.Search.Data/stable/2019-05-06/searchindex.json
Outdated
Show resolved
Hide resolved
...tion/search/data-plane/Microsoft.Azure.Search.Data/track1/stable/2019-05-06/searchindex.json
Outdated
Show resolved
Hide resolved
...cation/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...cation/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...cation/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...cation/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...search/data-plane/Microsoft.Azure.Search.Service/track1/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...search/data-plane/Microsoft.Azure.Search.Service/track1/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
...search/data-plane/Microsoft.Azure.Search.Service/track1/stable/2019-05-06/searchservice.json
Outdated
Show resolved
Hide resolved
|
Can one of the admins verify this patch? |
|
Context - @HeidiSteen - This is the logic we applied In places where the term "Azure Search" is followed by a noun ("Azure Search service", "Azure search index", "Azure search indexer etc.,") we simply contract it to "search" + noun or remove "search" altogether as appropriate ("search service", "index", "indexer" etc.,) |
HeidiSteen
left a comment
There was a problem hiding this comment.
@bleroy Your PR didn't pass validation. You should close and reopen the PR to see if the problem is transitory. I agree with all of Arvind's comments.
@HeidiSteen / @sarangan12 / @bleroy - the model validation failures are due to a "ENUM_MISMATCH" which is a known failure mode and we have obtained exceptions from the swagger folks. |
|
@sarangan12 - @brjohnstmsft is on vacation, and I think my sign off is a reasonable substitute. |
This applies branding changes from "Azure Search" to "Azure Cognitive Search".